TypedArray and ArrayBuffer support for @@species

src/js/arraybuffer.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, utils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
 // -------------------------------------------------------------------
 // Imports
 
 var GlobalArrayBuffer = global.ArrayBuffer;
 var MakeTypeError;
 var MaxSimple;
 var MinSimple;
+var SpeciesConstructor;
 
 utils.Import(function(from) {
   MakeTypeError = from.MakeTypeError;
   MaxSimple = from.MaxSimple;
   MinSimple = from.MinSimple;
+  SpeciesConstructor = from.SpeciesConstructor;
 });
 
 // -------------------------------------------------------------------
 
 function ArrayBufferGetByteLen() {
   if (!IS_ARRAYBUFFER(this)) {
     throw MakeTypeError(kIncompatibleMethodReceiver,
                         'ArrayBuffer.prototype.byteLength', this);
   }
   return %_ArrayBufferGetByteLength(this);
@@ skipping 22 matching lines @@
   if (relativeEnd < 0) {
     fin = MaxSimple(byte_length + relativeEnd, 0);
   } else {
     fin = MinSimple(relativeEnd, byte_length);
   }
 
   if (fin < first) {
     fin = first;
   }
   var newLen = fin - first;
-  // TODO(dslomov): implement inheritance
-  var result = new GlobalArrayBuffer(newLen);
+  var constructor = SpeciesConstructor(this, GlobalArrayBuffer, true);
+  var result = new constructor(newLen);
+  if (!IS_ARRAYBUFFER(result)) {

[adamk, 2016/01/12 00:11:00]

Is this exercised in some test?

[Dan Ehrenberg, 2016/01/12 01:38:33]

Test262, but that's not active yet so I wrote another test.

+    throw MakeTypeError(kIncompatibleMethodReceiver,
+                        'ArrayBuffer.prototype.slice', result);
+  }
+  if (%_ArrayBufferGetByteLength(result) < newLen) {

[adamk, 2016/01/12 00:11:00]

And this? Same question about most of these error cases.

[Dan Ehrenberg, 2016/01/12 01:38:33]

Oops, I forgot to add the file test/mjsunit/harmony/arraybuffer-species.js where
I had written a test for it. Now it's there.

+    throw MakeTypeError(kArrayBufferTooShort);
+  }
+  if (result === this) {

[adamk, 2016/01/12 00:11:00]

FWIW this check precedes the byte length check in the spec, might as well match
those checks?

[Dan Ehrenberg, 2016/01/12 01:38:33]

Was in test262, added an mjsunit test for it.

+    throw MakeTypeError(kArrayBufferSpeciesThis);
+  }
 
-  %ArrayBufferSliceImpl(this, result, first);
+  %ArrayBufferSliceImpl(this, result, first, newLen);
   return result;
 }
 
 utils.InstallGetter(GlobalArrayBuffer.prototype, "byteLength",
                     ArrayBufferGetByteLen);
 
 utils.InstallFunctions(GlobalArrayBuffer.prototype, DONT_ENUM, [
   "slice", ArrayBufferSlice
 ]);
 
 })