Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 15748002: Initial support for experimental touch-action CSS feature (Closed)

Created:
7 years, 7 months ago by Rick Byers
Modified:
7 years, 7 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, leviw+renderwatch, abarth-chromium, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, Scott Blomquist (MS OPEN TECH), Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Initial support for experimental touch-action CSS feature This adds basic parsing of CSS touch-action from the pointer events specification: http://www.w3.org/TR/pointerevents/. This first CL just adds the runtime enabled touch-action feature (currently test only) and parsing of the two basic values 'auto' and 'none'. Intent-to-implement thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/K1qk6qZWgIc. BUG=241964 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151158

Patch Set 1 #

Patch Set 2 : Fix Mac build and WebExposed test failure #

Patch Set 3 : Update for generated StyleBuilder just relanded in r150951 #

Total comments: 2

Patch Set 4 : Remove unnecessary CSSParserContext change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -2 lines) Patch
A LayoutTests/fast/css/touch-action-parsing.html View 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/touch-action-parsing-expected.txt View 1 chunk +33 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/public/WebRuntimeFeatures.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/css/CSSParserMode.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/RuntimeCSSEnabled.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Rick Byers
Hi Adam, Can you review this first CL for touch-action? There are a number of ...
7 years, 7 months ago (2013-05-22 15:55:48 UTC) #1
Rick Byers
Julien, Since this is mostly CSS goo, can you review it? I still need Adam ...
7 years, 7 months ago (2013-05-24 17:54:33 UTC) #2
abarth-chromium
The API change looks good, but I don't want to stamp the CL until the ...
7 years, 7 months ago (2013-05-24 17:56:52 UTC) #3
eseidel
lgtm An impressive amount of boilerplate. :( https://codereview.chromium.org/15748002/diff/9001/Source/core/css/CSSParserMode.h File Source/core/css/CSSParserMode.h (right): https://codereview.chromium.org/15748002/diff/9001/Source/core/css/CSSParserMode.h#newcode72 Source/core/css/CSSParserMode.h:72: bool isCSSTouchActionEnabled; ...
7 years, 7 months ago (2013-05-24 20:24:33 UTC) #4
Rick Byers
On 2013/05/24 20:24:33, eseidel wrote: > lgtm > > An impressive amount of boilerplate. :( ...
7 years, 7 months ago (2013-05-24 20:51:48 UTC) #5
abarth-chromium
API change LGTM
7 years, 7 months ago (2013-05-24 20:53:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/15748002/16001
7 years, 7 months ago (2013-05-24 20:54:00 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10186
7 years, 7 months ago (2013-05-24 22:25:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/15748002/16001
7 years, 7 months ago (2013-05-25 12:08:45 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6665
7 years, 7 months ago (2013-05-25 13:18:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/15748002/16001
7 years, 7 months ago (2013-05-25 17:50:42 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6683
7 years, 7 months ago (2013-05-25 18:54:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/15748002/16001
7 years, 7 months ago (2013-05-26 00:30:40 UTC) #13
commit-bot: I haz the power
7 years, 7 months ago (2013-05-26 00:31:16 UTC) #14
Message was sent while issue was closed.
Change committed as 151158

Powered by Google App Engine
This is Rietveld 408576698