device/bluetooth/bluetooth_gatt_service_unittest.cc - Issue 1574773002: bluetooth: android: Initial basic Descriptors implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_gatt_service_unittest.cc

Issue 1574773002: bluetooth: android: Initial basic Descriptors implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bta-code-cleanup-

Patch Set: Addressed jyasskin. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluetooth_gatt_characteristic_unittest.cc ('K') | « device/bluetooth/bluetooth_gatt_descriptor_unittest.cc ('k') | device/bluetooth/bluetooth_remote_gatt_characteristic_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_gatt_service_unittest.cc

diff --git a/device/bluetooth/bluetooth_gatt_service_unittest.cc b/device/bluetooth/bluetooth_gatt_service_unittest.cc

index e153cc5fce54a672a62d1fd83204b051e945b3b8..2d2faa75861085dba119eb71b0006d99cfc5ef5a 100644

--- a/device/bluetooth/bluetooth_gatt_service_unittest.cc

+++ b/device/bluetooth/bluetooth_gatt_service_unittest.cc

@@ -137,6 +137,10 @@ TEST_F(BluetoothGattServiceTest, GetCharacteristics_and_GetCharacteristic) {

EXPECT_EQ(char_uuid2, service->GetCharacteristic(char_id2)->GetUUID());

EXPECT_EQ(char_uuid3, service->GetCharacteristic(char_id3)->GetUUID());

EXPECT_EQ(char_uuid4, service->GetCharacteristic(char_id4)->GetUUID());

+ // Multiple GetCharacteristic calls for an ID return the same object:

+ EXPECT_EQ(service->GetCharacteristic(char_id1)->GetUUID(),

Jeffrey Yasskin 2016/01/12 23:25:59 Remove "->GetUUID()".

scheib 2016/01/12 23:54:46 Done.

+ service->GetCharacteristic(char_id1)->GetUUID());

}

#endif // defined(OS_ANDROID)