device/bluetooth/bluetooth_remote_gatt_service_android.cc - Issue 1574773002: bluetooth: android: Initial basic Descriptors implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_remote_gatt_service_android.cc

Issue 1574773002: bluetooth: android: Initial basic Descriptors implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bta-code-cleanup-

Patch Set: addressed j again Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth_remote_gatt_descriptor_android.cc ('k') | device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_remote_gatt_service_android.cc

diff --git a/device/bluetooth/bluetooth_remote_gatt_service_android.cc b/device/bluetooth/bluetooth_remote_gatt_service_android.cc

index a206c94806825cd1332f96e701191f3681a263f7..bfe2904fa8537b30b20ca64f01b2cb61fefcee46 100644

--- a/device/bluetooth/bluetooth_remote_gatt_service_android.cc

+++ b/device/bluetooth/bluetooth_remote_gatt_service_android.cc

@@ -192,7 +192,7 @@ void BluetoothRemoteGattServiceAndroid::CreateGattRemoteCharacteristic(

characteristics_.set(

instance_id_string,

BluetoothRemoteGattCharacteristicAndroid::Create(

- instance_id_string, bluetooth_gatt_characteristic_wrapper,

+ adapter_, instance_id_string, bluetooth_gatt_characteristic_wrapper,

chrome_bluetooth_device));

}

@@ -207,7 +207,7 @@ void BluetoothRemoteGattServiceAndroid::EnsureCharacteristicsCreated() const {

return;

// Java call

- Java_ChromeBluetoothRemoteGattService_ensureCharacteristicsCreated(

+ Java_ChromeBluetoothRemoteGattService_createCharacteristics(

AttachCurrentThread(), j_service_.obj());

}