Properly set UnlinkedReference.prefixReference in summaries.

Properly set UnlinkedReference.prefixReference in summaries.

This information will be necessary when a change to a file forces
summaries to be relinked.

Note that the way we determine the prefix is a bit kludgy: we look at
the export namespaces of the imported libraries and arbitrarily choose
a prefix that points to the given element.  This will give subtly
incorrect results if a name is reachable via multiple prefixes,
however this is unlikely to pose a problem in non-contrived use cases.
See the test
`fail_type_reference_to_type_visible_via_multiple_import_prefixes` for
a more detailed explanation of what might go wrong.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/8a29a992864bc0918bfd5f9eb2ff128211fab904

[Paul Berry, 2016-01-09 21:41:05]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2016-01-09 22:51:31]

LGTM

https://codereview.chromium.org/1574763002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_elements.dart (right):

https://codereview.chromium.org/1574763002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:288: for (ImportElement
import in libraryElement.imports) {
We could skip analyzing an import if it does not have any prefix.

[Paul Berry, 2016-01-09 23:25:44]

Description was changed from

==========
Properly set UnlinkedReference.prefixReference in summaries.

This information will be necessary when a change to a file forces
summaries to be relinked.

Note that the way we determine the prefix is a bit kludgy: we look at
the export namespaces of the imported libraries and arbitrarily choose
a prefix that points to the given element.  This will give subtly
incorrect results if a name is reachable via multiple prefixes,
however this is unlikely to pose a problem in non-contrived use cases.
See the test
`fail_type_reference_to_type_visible_via_multiple_import_prefixes` for
a more detailed explanation of what might go wrong.
==========

to

==========
Properly set UnlinkedReference.prefixReference in summaries.

This information will be necessary when a change to a file forces
summaries to be relinked.

Note that the way we determine the prefix is a bit kludgy: we look at
the export namespaces of the imported libraries and arbitrarily choose
a prefix that points to the given element.  This will give subtly
incorrect results if a name is reachable via multiple prefixes,
however this is unlikely to pose a problem in non-contrived use cases.
See the test
`fail_type_reference_to_type_visible_via_multiple_import_prefixes` for
a more detailed explanation of what might go wrong.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8a29a992864bc0918bfd5f9eb2ff128211fab904
==========

[Paul Berry, 2016-01-09 23:25:45]

Committed patchset #1 (id:1) manually as
8a29a992864bc0918bfd5f9eb2ff128211fab904 (presubmit successful).

[Paul Berry, 2016-01-10 02:08:28]

https://codereview.chromium.org/1574763002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_elements.dart (right):

https://codereview.chromium.org/1574763002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:288: for (ImportElement
import in libraryElement.imports) {
On 2016/01/09 22:51:31, scheglov wrote:
> We could skip analyzing an import if it does not have any prefix.

Done.

[Brian Wilkerson, 2016-01-10 16:18:38]

LGTM