Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1574753002:
Ensure Oilpan garbage is collected on JavaBridgeChildFrameTest test. (Closed)
DescriptionEnsure Oilpan garbage is collected on JavaBridgeChildFrameTest test.
In order for testHolderFrame's testing of the liveness of its weak
reference to be accurate with Oilpan is enabled, another GC round
is required to have both v8 and Oilpan GCs get to sweep out all
their dead objects before checking the weak reference.
R=haraken,jochen
BUG=575696
Committed: https://crrev.com/d896eb849bf10ee7f2b723564e81e471ab0cd858
Cr-Commit-Position: refs/heads/master@{#368550}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574753002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sigbjornf@opera.com changed reviewers: + jam@chromium.org, jochen@chromium.org, oilpan-reviews@chromium.org
please take a look. To prepare for enabling Oilpan everywhere, this unit test needs to crank the GC handle another turn before testing. See https://codereview.chromium.org/1517193002/#ps180001 for test results on linux_android_rel_ng w/ Oilpan enabled.
LGTM (We normally use 5 though.)
On 2016/01/10 02:40:16, haraken wrote: > LGTM > > (We normally use 5 though.) Yes, 5 (or 7) for global test helpers reqd to reliably work over any v8 <-> Blink entangled object graphs, makes sense. Needing such a deep count here would hide a problem, was how I argued.
Description was changed from ========== Ensure Oilpan garbage is collected on JavaBridgeChildFrameTest test. In order for testHolderFrame's testing of the liveness of its weak reference to be accurate with Oilpan is enabled, another GC round is required to have both v8 and Oilpan GCs get to sweep out all their dead objects before checking the weak reference. R= BUG=575696 ========== to ========== Ensure Oilpan garbage is collected on JavaBridgeChildFrameTest test. In order for testHolderFrame's testing of the liveness of its weak reference to be accurate with Oilpan is enabled, another GC round is required to have both v8 and Oilpan GCs get to sweep out all their dead objects before checking the weak reference. R=haraken BUG=575696 ==========
(needs content/ owner approval.)
jochen@chromium.org changed reviewers: + haraken@chromium.org
lgtm
Description was changed from ========== Ensure Oilpan garbage is collected on JavaBridgeChildFrameTest test. In order for testHolderFrame's testing of the liveness of its weak reference to be accurate with Oilpan is enabled, another GC round is required to have both v8 and Oilpan GCs get to sweep out all their dead objects before checking the weak reference. R=haraken BUG=575696 ========== to ========== Ensure Oilpan garbage is collected on JavaBridgeChildFrameTest test. In order for testHolderFrame's testing of the liveness of its weak reference to be accurate with Oilpan is enabled, another GC round is required to have both v8 and Oilpan GCs get to sweep out all their dead objects before checking the weak reference. R=haraken,jochen BUG=575696 ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574753002/1
Message was sent while issue was closed.
Description was changed from ========== Ensure Oilpan garbage is collected on JavaBridgeChildFrameTest test. In order for testHolderFrame's testing of the liveness of its weak reference to be accurate with Oilpan is enabled, another GC round is required to have both v8 and Oilpan GCs get to sweep out all their dead objects before checking the weak reference. R=haraken,jochen BUG=575696 ========== to ========== Ensure Oilpan garbage is collected on JavaBridgeChildFrameTest test. In order for testHolderFrame's testing of the liveness of its weak reference to be accurate with Oilpan is enabled, another GC round is required to have both v8 and Oilpan GCs get to sweep out all their dead objects before checking the weak reference. R=haraken,jochen BUG=575696 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Ensure Oilpan garbage is collected on JavaBridgeChildFrameTest test. In order for testHolderFrame's testing of the liveness of its weak reference to be accurate with Oilpan is enabled, another GC round is required to have both v8 and Oilpan GCs get to sweep out all their dead objects before checking the weak reference. R=haraken,jochen BUG=575696 ========== to ========== Ensure Oilpan garbage is collected on JavaBridgeChildFrameTest test. In order for testHolderFrame's testing of the liveness of its weak reference to be accurate with Oilpan is enabled, another GC round is required to have both v8 and Oilpan GCs get to sweep out all their dead objects before checking the weak reference. R=haraken,jochen BUG=575696 Committed: https://crrev.com/d896eb849bf10ee7f2b723564e81e471ab0cd858 Cr-Commit-Position: refs/heads/master@{#368550} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d896eb849bf10ee7f2b723564e81e471ab0cd858 Cr-Commit-Position: refs/heads/master@{#368550} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
