Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2421)

Unified Diff: chrome/browser/resources/apps_debugger/background.js

Issue 15747009: Use window singleton API in the App Developer Tool and simplify the code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@devtools-style-2
Patch Set: apps_debugger -> apps_devtool Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/apps_debugger/background.js
diff --git a/chrome/browser/resources/apps_debugger/background.js b/chrome/browser/resources/apps_debugger/background.js
index d5042da674f96253b73ca5b698473784f320f2cd..0b16d8c47163052fc2921847ba5403bad3b89bbb 100644
--- a/chrome/browser/resources/apps_debugger/background.js
+++ b/chrome/browser/resources/apps_debugger/background.js
@@ -4,17 +4,11 @@
var mainWindow = null;
chrome.app.runtime.onLaunched.addListener(function() {
- if (mainWindow && !mainWindow.contentWindow.closed) {
Dan Beam 2013/05/23 19:58:42 so removing this lets there be multiple apps inste
- mainWindow.focus();
- } else {
- chrome.app.window.create('main.html', {
- id: 'apps_debugger',
- minHeight: 600,
- minWidth: 800,
- height: 600,
- width: 800,
- }, function(win) {
- mainWindow = win;
- });
- }
+ chrome.app.window.create('main.html', {
+ id: 'apps_devtool',
+ minHeight: 600,
+ minWidth: 800,
+ height: 600,
+ width: 800,
Dan Beam 2013/05/23 20:12:38 where's singleton: true, ?
Gaurav 2013/05/23 20:23:59 I think it will be good to add it explicity. On 20
+ });
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698