Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1574643002: Adding aseemgarg and bradnelson to OWNERS for asm typer. (Closed)

Created:
4 years, 11 months ago by bradnelson
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding aseemgarg and bradnelson to OWNERS for asm typer. BUG= R=titzer@chromium.org Committed: https://crrev.com/c4a6af7fdadf7a90cb6eff6ce78a762bd1392879 Cr-Commit-Position: refs/heads/master@{#33204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
bradn
4 years, 11 months ago (2016-01-09 01:15:30 UTC) #2
titzer
lgtm
4 years, 11 months ago (2016-01-11 09:28:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574643002/1
4 years, 11 months ago (2016-01-11 10:47:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/12800)
4 years, 11 months ago (2016-01-11 12:40:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574643002/1
4 years, 11 months ago (2016-01-11 12:41:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 12:59:15 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 13:00:07 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c4a6af7fdadf7a90cb6eff6ce78a762bd1392879
Cr-Commit-Position: refs/heads/master@{#33204}

Powered by Google App Engine
This is Rietveld 408576698