Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 157463002: Make LeakSanitizer happy, part 3. (Closed)

Created:
6 years, 10 months ago by Sven Panne
Modified:
6 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Make LeakSanitizer happy, part 3. Fixed a few more cctests and removed some which were broken for ages and/or tested nothing useful anymore. Note that cctests are now fully LeakSanitized (at least on x64)! R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19195

Patch Set 1 #

Patch Set 2 : re-uploaded because of codereview troubles #

Patch Set 3 : re-uploaded because of codereview troubles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -120 lines) Patch
M test/cctest/test-api.cc View 7 chunks +17 lines, -120 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sven Panne
re-uploaded because of codereview troubles
6 years, 10 months ago (2014-02-07 12:14:35 UTC) #1
Sven Panne
re-uploaded because of codereview troubles
6 years, 10 months ago (2014-02-07 12:15:16 UTC) #2
Sven Panne
6 years, 10 months ago (2014-02-07 12:16:10 UTC) #3
dcarney
lgtm
6 years, 10 months ago (2014-02-07 12:17:02 UTC) #4
Sven Panne
6 years, 10 months ago (2014-02-07 12:17:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r19195 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698