Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1574603002: Make SkROBuffer::Iter::size() work when exhausted (Closed)

Created:
4 years, 11 months ago by scroggo
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkROBuffer::Iter::size() work when exhausted According to the documentation, this method will return 0 when the Iter is exhausted. Prior to this CL, it crashes instead. Prevent a crash with a null fHead, and add a test to verify the behavior. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1574603002 Committed: https://skia.googlesource.com/skia/+/b512aaa5c808bcb1336c147682657882ee54e652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/core/SkRWBuffer.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/DataRefTest.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
scroggo
4 years, 11 months ago (2016-01-08 22:31:41 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574603002/1
4 years, 11 months ago (2016-01-08 22:31:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 22:53:29 UTC) #7
reed1
lgtm
4 years, 11 months ago (2016-01-09 01:11:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574603002/1
4 years, 11 months ago (2016-01-11 14:20:19 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 14:38:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b512aaa5c808bcb1336c147682657882ee54e652

Powered by Google App Engine
This is Rietveld 408576698