Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 15746017: Move webkit/blob to new locations. (Closed)

Created:
7 years, 7 months ago by michaeln
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org
Visibility:
Public.

Description

Move webkit/blob to new locations. Also move content::WebBlobRegistryImpl to the new common_child library. - just moving the files in the source repository - and fixing up complilation guards - and fixing up include paths throughout - and fixing up DEPs files as needed Note: Everything in /webkit is still being built into the same old webkit_storage target for now, new actual build target(s) will come later. TBR=kinuko@chromium.org, thestig@chromium.org BUG=239109 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202762

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : #

Total comments: 1

Patch Set 8 : #

Total comments: 6

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -4576 lines) Patch
M chrome/browser/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/webkit_file_stream_reader_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/device_media_async_file_util.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/chrome_blob_storage_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/view_blob_internals_job_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/fileapi/webblob_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
D content/common/fileapi/webblobregistry_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -36 lines 0 comments Download
D content/common/fileapi/webblobregistry_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -126 lines 0 comments Download
A + content/common_child/webblobregistry_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/common_child/webblobregistry_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_common_child.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -1 line 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
D webkit/blob/OWNERS View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -1 line 0 comments Download
D webkit/blob/blob_data.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -102 lines 0 comments Download
D webkit/blob/blob_data.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -69 lines 0 comments Download
D webkit/blob/blob_data_handle.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -50 lines 0 comments Download
D webkit/blob/blob_data_handle.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/blob/blob_storage_context.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -110 lines 0 comments Download
D webkit/blob/blob_storage_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -322 lines 0 comments Download
D webkit/blob/blob_storage_context_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -206 lines 0 comments Download
D webkit/blob/blob_storage_controller.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -82 lines 0 comments Download
D webkit/blob/blob_storage_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -257 lines 0 comments Download
D webkit/blob/blob_storage_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -77 lines 0 comments Download
D webkit/blob/blob_storage_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -69 lines 0 comments Download
D webkit/blob/blob_storage_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -111 lines 0 comments Download
D webkit/blob/blob_url_request_job.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -119 lines 0 comments Download
D webkit/blob/blob_url_request_job.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -607 lines 0 comments Download
D webkit/blob/blob_url_request_job_factory.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -58 lines 0 comments Download
D webkit/blob/blob_url_request_job_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -48 lines 0 comments Download
D webkit/blob/blob_url_request_job_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -451 lines 0 comments Download
D webkit/blob/file_stream_reader.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/blob/local_file_stream_reader.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -83 lines 0 comments Download
D webkit/blob/local_file_stream_reader.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -167 lines 0 comments Download
D webkit/blob/local_file_stream_reader_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -261 lines 0 comments Download
D webkit/blob/mock_blob_url_request_context.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -52 lines 0 comments Download
D webkit/blob/mock_blob_url_request_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -74 lines 0 comments Download
D webkit/blob/scoped_file.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -94 lines 0 comments Download
D webkit/blob/scoped_file.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -83 lines 0 comments Download
D webkit/blob/shareable_file_reference.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -74 lines 0 comments Download
D webkit/blob/shareable_file_reference.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -119 lines 0 comments Download
D webkit/blob/shareable_file_reference_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -59 lines 0 comments Download
D webkit/blob/view_blob_internals_job.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -57 lines 0 comments Download
D webkit/blob/view_blob_internals_job.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -248 lines 0 comments Download
D webkit/blob/webkit_blob.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -32 lines 0 comments Download
A + webkit/browser/blob/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/browser/blob/blob_data_handle.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/blob/blob_data_handle.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
A + webkit/browser/blob/blob_storage_context.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/blob/blob_storage_context.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
A + webkit/browser/blob/blob_storage_context_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webkit/browser/blob/blob_storage_controller.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/blob/blob_storage_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/browser/blob/blob_storage_controller_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/browser/blob/blob_storage_host.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/blob/blob_storage_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webkit/browser/blob/blob_url_request_job.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/blob/blob_url_request_job.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/blob/blob_url_request_job_factory.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/blob/blob_url_request_job_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +4 lines, -4 lines 0 comments Download
A + webkit/browser/blob/blob_url_request_job_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -6 lines 0 comments Download
A + webkit/browser/blob/file_stream_reader.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/browser/blob/local_file_stream_reader.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/blob/local_file_stream_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/blob/local_file_stream_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/blob/mock_blob_url_request_context.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/browser/blob/mock_blob_url_request_context.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -4 lines 0 comments Download
A + webkit/browser/blob/view_blob_internals_job.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/blob/view_blob_internals_job.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
A webkit/browser/blob/webkit_browser_blob.gypi View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
M webkit/browser/chromeos/fileapi/remote_file_stream_writer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/async_file_util_adapter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/cross_operation_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_file_stream_reader.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_file_stream_reader.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_file_util.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/isolated_file_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/isolated_mount_point_provider.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_system_operation.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_system_operation.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_system_operation_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_system_operation_write_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/syncable/canned_syncable_file_system.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/syncable/local_file_change_tracker_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/syncable/local_file_sync_context_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/syncable/syncable_file_operation_runner_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/syncable/syncable_file_system_operation.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/transient_file_util_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/upload_file_system_file_element_reader.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/webkit_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -0 lines 0 comments Download
A + webkit/common/blob/blob_data.h View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/common/blob/blob_data.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/blob/scoped_file.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/common/blob/scoped_file.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/blob/shareable_file_reference.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/common/blob/shareable_file_reference.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/blob/shareable_file_reference_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A webkit/common/blob/webkit_common_blob.gypi View 1 2 3 4 5 6 7 8 1 chunk +16 lines, -0 lines 0 comments Download
MM webkit/common/webkit_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/glue/resource_request_body.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/resource_request_body_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/storage/webkit_storage.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_shell_request_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webblobregistry_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
michaeln
about to upload and start a new tryjob that i think has a chance of ...
7 years, 7 months ago (2013-05-24 19:28:25 UTC) #1
michaeln
https://codereview.chromium.org/15746017/diff/105001/chrome/browser/DEPS File chrome/browser/DEPS (right): https://codereview.chromium.org/15746017/diff/105001/chrome/browser/DEPS#newcode56 chrome/browser/DEPS:56: "+webkit/common/user_agent", oh... i can delete the +webkit/common/subdirs here given ...
7 years, 7 months ago (2013-05-24 19:59:32 UTC) #2
jamesr
I don't think this patch uploaded fully - I can't see the diffs for the ...
7 years, 7 months ago (2013-05-24 20:03:44 UTC) #3
michaeln
new snapshot uploaded, i have to poke at include ordering and see what the trybots ...
7 years, 7 months ago (2013-05-24 20:14:24 UTC) #4
michaeln
having troubles uploading?? Error fetching svn://chrome-svn/chrome/trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc?rev=201961: InvalidURLError: Invalid request URL: svn://chrome-svn/chrome/trunk/src/webkit/tools/test_shell/simple_resource_loader_bridge.cc?rev=201961
7 years, 7 months ago (2013-05-24 20:16:21 UTC) #5
michaeln
have to sync again, things have changed underneath
7 years, 7 months ago (2013-05-24 20:18:00 UTC) #6
jamesr
A few things need their #include sections re-sorted but it's looking quite reasonable so far. ...
7 years, 7 months ago (2013-05-24 20:30:46 UTC) #7
michaeln
i'll ping when i have a new upload i'm going to leave the shareable_file_ref and ...
7 years, 7 months ago (2013-05-24 20:45:25 UTC) #8
michaeln
freakin 3 hrs later, i finally have a new sync
7 years, 7 months ago (2013-05-24 23:42:15 UTC) #9
michaeln
maybe i can run tryjobs if the patch applies :/
7 years, 7 months ago (2013-05-25 00:36:29 UTC) #10
kinuko
lgtm
7 years, 7 months ago (2013-05-27 10:43:38 UTC) #11
michaeln
On 2013/05/27 10:43:38, kinuko wrote: > lgtm gah... the complile steps for my tryjobs are ...
7 years, 6 months ago (2013-05-29 02:46:20 UTC) #12
Lei Zhang
chrome/ lgtm, though I think you may have some conflicts?
7 years, 6 months ago (2013-05-29 02:59:00 UTC) #13
michaeln
7 years, 6 months ago (2013-05-29 03:09:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #14 manually as r202762.

Powered by Google App Engine
This is Rietveld 408576698