Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/gfx/render_text_unittest.cc

Issue 15746013: Fix cursor positioning regression from r201136. GetCursorPos() shouldn't assume (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/gfx/render_text_mac.cc ('K') | « ui/gfx/render_text_mac.cc ('k') | ui/gfx/render_text_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_unittest.cc
===================================================================
--- ui/gfx/render_text_unittest.cc (revision 201137)
+++ ui/gfx/render_text_unittest.cc (working copy)
@@ -285,9 +285,7 @@
}
// GetGlyphBounds() should yield the entire string bounds for text index 0.
- int height = 0;
- ui::Range bounds;
- render_text->GetGlyphBounds(0U, &bounds, &height);
+ ui::Range bounds(render_text->GetGlyphBounds(0U));
msw 2013/05/23 21:07:27 nit: you can inline this call below and eliminate
Peter Kasting 2013/05/23 21:09:11 Good point.
EXPECT_EQ(render_text->GetStringSize().width(),
static_cast<int>(bounds.length()));
« ui/gfx/render_text_mac.cc ('K') | « ui/gfx/render_text_mac.cc ('k') | ui/gfx/render_text_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698