Issue 157453003: Unify function parameter checking in PreParser and Parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 157453003: Unify function parameter checking in PreParser and Parser. (Closed)

Created:
6 years, 10 months ago by marja

Modified:
6 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Unify function parameter checking in PreParser and Parser. This also makes the "delayed strict mode violations" mechanism in PreParser unnecessary. The attached tests didn't pass before this CL but now they do. BUG=v8:3126 LOG=N R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19197

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -92 lines)			Patch
M	src/parser.cc	View	4 chunks	+18 lines, -13 lines	0 comments	Download
M	src/preparser.h	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	src/preparser.cc	View	8 chunks	+43 lines, -65 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 chunk	+37 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

marja

6 years, 10 months ago (2014-02-07 12:44:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #4 manually as r19197 (presubmit successful).