Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1574523002: add enableAsync to analysis option file flags (Closed)

Created:
4 years, 11 months ago by danrubel
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add enableAsync to analysis option file flags integrate enableAsync into analysis server include enableAsync on context status page update api spec to indicate that enableAsync is no longer deprecated relys on landing https://codereview.chromium.org/1570183002/ fixes #25373 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/2ae3026c43979c5991129537f7a2a6d2ecd751dc

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge #

Patch Set 3 : re-deprecate enableAsync API #

Patch Set 4 : disconnect deprecated enableAsync client API #

Patch Set 5 : format #

Patch Set 6 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danrubel
4 years, 11 months ago (2016-01-08 17:52:43 UTC) #2
Brian Wilkerson
Long term we don't want clients to have to globally enable/disable async support. Is there ...
4 years, 11 months ago (2016-01-08 18:51:35 UTC) #3
danrubel
On 2016/01/08 18:51:35, Brian Wilkerson wrote: > Long term we don't want clients to have ...
4 years, 11 months ago (2016-01-08 23:22:44 UTC) #4
Brian Wilkerson
LGTM, thanks!
4 years, 11 months ago (2016-01-09 00:01:20 UTC) #5
danrubel
4 years, 11 months ago (2016-01-09 01:48:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
2ae3026c43979c5991129537f7a2a6d2ecd751dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698