Restyle omnibox popup

chrome/browser/ui/views/location_bar/location_bar_view.cc

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index c134a8a4d31d565f972a7ab81f1821f555ab269a..efdd1cb71f1a32939ac650c78bd8686c0837776a 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -427,6 +427,28 @@ SkColor LocationBarView::GetColor(ToolbarModel::SecurityLevel security_level,
   }
 }
 
+void LocationBarView::GetOmniboxPopupPositioningInfo(
+    gfx::Point* top_left_screen_coord,
+    int* popup_width,
+    int* left_margin,
+    int* right_margin) {
+  gfx::Rect location_bar_bounds(parent()->GetContentsBounds());
+
+  // The location bar is drawn using a background graphic that includes the
+  // border, so we inset by enough to make the edges line up, and the bubble
+  // appear at the same height as the Star bubble.

[Peter Kasting, 2013/06/06 22:52:04]

Nit: I'd just nuke this comment (and the blank line above it); the first half
should already be well-known to someone reading this code, and the second half
is no longer relevant.

Also, it seems like maybe you'd want to inset (both sides?) by GetItemPadding()
as well?  I suspect this currently happens in the code that draws the rows
inside the popup, at least for the left side, but maybe it'd be simpler or
clearer to do it here.  Insetting both ends by GetItemPadding() would mean you'd
have the exact offset that the icon should start at as well as the exact width
until we elide the omnibox text.

+  location_bar_bounds.Inset(kNormalEdgeThickness, 0);
+
+  *top_left_screen_coord = gfx::Point(0, parent()->height());
+  views::View::ConvertPointToScreen(parent(), top_left_screen_coord);
+  *popup_width = parent()->width();
+
+  gfx::Point location_bar_in_toolbar(location_bar_bounds.origin());
+  views::View::ConvertPointToTarget(this, parent(), &location_bar_in_toolbar);
+  *left_margin = location_bar_in_toolbar.x();
+  *right_margin = *popup_width - *left_margin - location_bar_bounds.width();
+}
+
 // static
 int LocationBarView::GetItemPadding() {
   const int kTouchItemPadding = 8;