Restyle omnibox popup

chrome/browser/ui/views/location_bar/location_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/command_line.h"
@@ skipping 409 matching lines @@
       return color_utils::GetReadableColor(
           color, GetColor(security_level, BACKGROUND));
     }
 
     default:
       NOTREACHED();
       return GetColor(security_level, TEXT);
   }
 }
 
+void LocationBarView::GetOmniboxPopupPositioningInfo(
+    gfx::Point* top_left_screen_coord,
+    int* popup_width,
+    int* left_margin,
+    int* right_margin) {
+  gfx::Rect location_bar_bounds(parent()->GetContentsBounds());
+
+  // The location bar is drawn using a background graphic that includes the
+  // border, so we inset by enough to make the edges line up, and the bubble
+  // appear at the same height as the Star bubble.

[Peter Kasting, 2013/06/06 22:52:04]

Nit: I'd just nuke this comment (and the blank line above it); the first half
should already be well-known to someone reading this code, and the second half
is no longer relevant.

Also, it seems like maybe you'd want to inset (both sides?) by GetItemPadding()
as well?  I suspect this currently happens in the code that draws the rows
inside the popup, at least for the left side, but maybe it'd be simpler or
clearer to do it here.  Insetting both ends by GetItemPadding() would mean you'd
have the exact offset that the icon should start at as well as the exact width
until we elide the omnibox text.

+  location_bar_bounds.Inset(kNormalEdgeThickness, 0);
+
+  *top_left_screen_coord = gfx::Point(0, parent()->height());
+  views::View::ConvertPointToScreen(parent(), top_left_screen_coord);
+  *popup_width = parent()->width();
+
+  gfx::Point location_bar_in_toolbar(location_bar_bounds.origin());
+  views::View::ConvertPointToTarget(this, parent(), &location_bar_in_toolbar);
+  *left_margin = location_bar_in_toolbar.x();
+  *right_margin = *popup_width - *left_margin - location_bar_bounds.width();
+}
+
 // static
 int LocationBarView::GetItemPadding() {
   const int kTouchItemPadding = 8;
   if (ui::GetDisplayLayout() == ui::LAYOUT_TOUCH)
     return kTouchItemPadding;
 
   const int kDesktopScriptBadgeItemPadding = 9;
   const int kDesktopItemPadding = 3;
   return extensions::FeatureSwitch::script_badges()->IsEnabled() ?
       kDesktopScriptBadgeItemPadding : kDesktopItemPadding;
@@ skipping 1093 matching lines @@
 int LocationBarView::GetInternalHeight(bool use_preferred_size) {
   int total_height =
       use_preferred_size ? GetPreferredSize().height() : height();
   return std::max(total_height - (vertical_edge_thickness() * 2), 0);
 }
 
 bool LocationBarView::HasValidSuggestText() const {
   return suggested_text_view_->visible() &&
       !suggested_text_view_->size().IsEmpty();
 }