Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 15745031: Restyle omnibox popup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Go back to 3 max search suggestions for now Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 // Selection persisted across temporary text changes, like popup suggestions. 173 // Selection persisted across temporary text changes, like popup suggestions.
174 ui::Range saved_temporary_selection_; 174 ui::Range saved_temporary_selection_;
175 175
176 // Tracking state before and after a possible change. 176 // Tracking state before and after a possible change.
177 string16 text_before_change_; 177 string16 text_before_change_;
178 ui::Range sel_before_change_; 178 ui::Range sel_before_change_;
179 bool ime_composing_before_change_; 179 bool ime_composing_before_change_;
180 180
181 // Was the delete key pressed with an empty selection at the end of the edit? 181 // Was the delete key pressed with an empty selection at the end of the edit?
182 bool delete_at_end_pressed_; 182 bool delete_at_end_pressed_;
183
183 LocationBarView* location_bar_view_; 184 LocationBarView* location_bar_view_;
185 views::View* webview_;
Peter Kasting 2013/06/06 18:52:16 You don't seem to make use of this new member
184 186
185 // True if the IME candidate window is open. When this is true, we want to 187 // True if the IME candidate window is open. When this is true, we want to
186 // avoid showing the popup. So far, the candidate window is detected only 188 // avoid showing the popup. So far, the candidate window is detected only
187 // on Chrome OS. 189 // on Chrome OS.
188 bool ime_candidate_window_open_; 190 bool ime_candidate_window_open_;
189 191
190 // Should we select all the text when we see the mouse button get released? 192 // Should we select all the text when we see the mouse button get released?
191 // We select in response to a click that focuses the omnibox, but we defer 193 // We select in response to a click that focuses the omnibox, but we defer
192 // until release, setting this variable back to false if we saw a drag, to 194 // until release, setting this variable back to false if we saw a drag, to
193 // allow the user to select just a portion of the text. 195 // allow the user to select just a portion of the text.
194 bool select_all_on_mouse_release_; 196 bool select_all_on_mouse_release_;
195 197
196 // Indicates if we want to select all text in the omnibox when we get a 198 // Indicates if we want to select all text in the omnibox when we get a
197 // GESTURE_TAP. We want to select all only when the textfield is not in focus 199 // GESTURE_TAP. We want to select all only when the textfield is not in focus
198 // and gets a tap. So we use this variable to remember focus state before tap. 200 // and gets a tap. So we use this variable to remember focus state before tap.
199 bool select_all_on_gesture_tap_; 201 bool select_all_on_gesture_tap_;
200 202
201 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews); 203 DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews);
202 }; 204 };
203 205
204 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_ 206 #endif // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698