Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4309)

Unified Diff: chrome/browser/extensions/extension_warning_badge_service.cc

Issue 15745022: Add custom icon support to GlobalError. Show extension icon in permissions increase bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: no icon ok Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_warning_badge_service.cc
diff --git a/chrome/browser/extensions/extension_warning_badge_service.cc b/chrome/browser/extensions/extension_warning_badge_service.cc
index 59edff795b36c5268c565dad1116b6951743b4d9..ffce47a2fd788ea1e9de5e76915648bd67b3dcae 100644
--- a/chrome/browser/extensions/extension_warning_badge_service.cc
+++ b/chrome/browser/extensions/extension_warning_badge_service.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/ui/browser_commands.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
+#include "ui/gfx/image/image.h"
namespace extensions {
@@ -32,6 +33,7 @@ class ErrorBadge : public GlobalError {
virtual void ExecuteMenuItem(Browser* browser) OVERRIDE;
virtual bool HasBubbleView() OVERRIDE;
+ virtual gfx::Image GetBubbleViewIcon() OVERRIDE;
virtual string16 GetBubbleViewTitle() OVERRIDE;
virtual std::vector<string16> GetBubbleViewMessages() OVERRIDE;
virtual string16 GetBubbleViewAcceptButtonLabel() OVERRIDE;
@@ -77,6 +79,10 @@ bool ErrorBadge::HasBubbleView() {
return false;
}
+gfx::Image ErrorBadge::GetBubbleViewIcon() {
+ return gfx::Image();
+}
+
string16 ErrorBadge::GetBubbleViewTitle() {
return string16();
}

Powered by Google App Engine
This is Rietveld 408576698