Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2916)

Unified Diff: chrome/browser/ui/cocoa/global_error_bubble_controller.mm

Issue 15745022: Add custom icon support to GlobalError. Show extension icon in permissions increase bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: no defaults Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/global_error_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/global_error_bubble_controller.mm b/chrome/browser/ui/cocoa/global_error_bubble_controller.mm
index 778881706ddd9816659a8d7e8285e169127d76ae..c8b5d3b48b056b9f7881dc99d8d6d15503dfdeeb 100644
--- a/chrome/browser/ui/cocoa/global_error_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/global_error_bubble_controller.mm
@@ -23,7 +23,6 @@
#include "grit/generated_resources.h"
#import "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h"
#include "ui/base/l10n/l10n_util.h"
-#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/image/image.h"
namespace {
@@ -83,9 +82,9 @@ class Bridge : public GlobalErrorBubbleViewBase {
DCHECK(error_);
- ResourceBundle& rb = ResourceBundle::GetSharedInstance();
- [iconView_ setImage:rb.GetNativeImageNamed(
- error_->GetBubbleViewIconResourceID()).ToNSImage()];
+ gfx::Image image = error_->GetBubbleViewIcon();
+ DCHECK(!image.IsEmpty());
+ [iconView_ setImage:image.ToNSImage()];
[title_ setStringValue:SysUTF16ToNSString(error_->GetBubbleViewTitle())];
std::vector<string16> messages = error_->GetBubbleViewMessages();

Powered by Google App Engine
This is Rietveld 408576698