Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: scripts/slave/recipes/findit/chromium/compile.py

Issue 1574433004: Allow a single trybot to mirror multiple waterfall bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@bot-config-and-test-db
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/findit/chromium/compile.py
diff --git a/scripts/slave/recipes/findit/chromium/compile.py b/scripts/slave/recipes/findit/chromium/compile.py
index 69a0e80d4f2b08a086527c600858fbc727954dab..4e9251df7597954f604a1ac2a9a33a57d6933ff4 100644
--- a/scripts/slave/recipes/findit/chromium/compile.py
+++ b/scripts/slave/recipes/findit/chromium/compile.py
@@ -49,11 +49,12 @@ class CompileResult(object):
def _run_compile_at_revision(api, target_mastername, target_buildername,
revision, compile_targets, use_analyze):
with api.step.nest('test %s' % str(revision)):
+ bot_desc = api.chromium_tests.create_bot_desc(
+ target_mastername, target_buildername)
# Checkout code at the given revision to recompile.
bot_update_step, bot_db = \
api.chromium_tests.prepare_checkout(
- target_mastername,
- target_buildername,
+ bot_desc,
root_solution_revision=revision)
# TODO(http://crbug.com/560991): if compile targets are provided, check
@@ -62,8 +63,7 @@ def _run_compile_at_revision(api, target_mastername, target_buildername,
compile_targets = sorted(set(compile_targets or []))
if not compile_targets:
compile_targets, _ = api.chromium_tests.get_compile_targets_and_tests(
- target_mastername,
- target_buildername,
+ bot_desc,
bot_db,
override_bot_type='builder_tester')
@@ -104,13 +104,14 @@ def _run_compile_at_revision(api, target_mastername, target_buildername,
def RunSteps(api, target_mastername, target_buildername,
good_revision, bad_revision,
requested_compile_targets, use_analyze):
+ bot_desc = api.chromium_tests.create_bot_desc(
+ target_mastername, target_buildername)
api.chromium_tests.configure_build(
- target_mastername, target_buildername, override_bot_type='builder_tester')
+ bot_desc, override_bot_type='builder_tester')
# Sync to bad revision, and retrieve revisions in the regression range.
api.chromium_tests.prepare_checkout(
- target_mastername, target_buildername,
- root_solution_revision=bad_revision)
+ bot_desc, root_solution_revision=bad_revision)
revisions_to_check = api.findit.revisions_between(good_revision, bad_revision)
results = []

Powered by Google App Engine
This is Rietveld 408576698