Issue 157443002: Add basic support for STL containers allocated in Zones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 157443002: Add basic support for STL containers allocated in Zones (Closed)

Created:
6 years, 10 months ago by danno

Modified:
6 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add basic support for STL containers allocated in Zones R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19194

Patch Set 2 : Review feedback #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -26 lines)			Patch
M	src/list.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/utils.h	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
A +	src/zone-allocator.h	View	1	1 chunk	+42 lines, -18 lines	0 comments	Download
A +	src/zone-containers.h	View		2 chunks	+12 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. https://codereview.chromium.org/157443002/diff/1/src/utils.h File src/utils.h (right): https://codereview.chromium.org/157443002/diff/1/src/utils.h#newcode1142 src/utils.h:1142: nit: two empty lines please (doesn't ...

6 years, 10 months ago (2014-02-07 11:48:03 UTC) #2

danno

6 years, 10 months ago (2014-02-07 11:55:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19194 (presubmit successful).

Expand Messages | Collapse Messages

Issue 157443002: Add basic support for STL containers allocated in Zones (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review feedback #

Messages