Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 15744002: Fix VisitLogicalExpression for empty blocks on RHS. (Closed)

Created:
7 years, 7 months ago by Michael Starzinger
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix VisitLogicalExpression for empty blocks on RHS. R=jkummerow@chromium.org BUG=chromium:242870 TEST=mjsunit/regress/regress-crbug-242870 Committed: http://code.google.com/p/v8/source/detail?r=14747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-242870.js View 1 chunk +10 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 7 months ago (2013-05-22 13:03:30 UTC) #1
Jakob Kummerow
lgtm
7 years, 7 months ago (2013-05-22 13:18:58 UTC) #2
Michael Starzinger
7 years, 7 months ago (2013-05-22 13:27:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14747 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698