Issue 1574393002: Fix simarm and simmips builds on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1574393002: Fix simarm and simmips builds on Mac. (Closed)

Created:
4 years, 11 months ago by rmacnak

Modified:
4 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix simarm and simmips builds on Mac. Broken by a7ebeb00fbb09b774836239b31d2c7defcc12c9c. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/87eae28239f285d9e363e0cd2075b07592a50a41

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	runtime/vm/simulator_arm.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	runtime/vm/simulator_mips.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 6 (3 generated)

rmacnak

4 years, 11 months ago (2016-01-12 20:47:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
87eae28239f285d9e363e0cd2075b07592a50a41 (presubmit successful).