Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1574373002: Revert of [DevTools] More Device Mode polish. (Closed)

Created:
4 years, 11 months ago by pfeldman
Modified:
4 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] More Device Mode polish. (patchset #1 id:1 of https://codereview.chromium.org/1575203003/ ) Reason for revert: Breaks responsive mode. Original issue's description: > [DevTools] More Device Mode polish. > > - fixed ruler in overlay with page scale factor; > - dimming zoom label based on some content being cropped; > - added dpr and ua type labels; > - fixed fit calculations; > - string updates. > > BUG=540864 > > Committed: https://crrev.com/a15860e14bdca7cba13cad960008e0581836b93b > Cr-Commit-Position: refs/heads/master@{#368822} TBR=dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540864 Committed: https://crrev.com/012c3f9ac6c5568c80a7929eed4ae34a84f8135a Cr-Commit-Position: refs/heads/master@{#368950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -78 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 8 chunks +7 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 9 chunks +7 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/deviceModeView.css View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
pfeldman
Created Revert of [DevTools] More Device Mode polish.
4 years, 11 months ago (2016-01-12 19:34:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574373002/1
4 years, 11 months ago (2016-01-12 19:35:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 19:36:45 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 19:37:35 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/012c3f9ac6c5568c80a7929eed4ae34a84f8135a
Cr-Commit-Position: refs/heads/master@{#368950}

Powered by Google App Engine
This is Rietveld 408576698