Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1574363002: Use classifying token position for control flow IR instructions (Closed)

Created:
4 years, 11 months ago by Cutch
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use classifying token position for control flow IR instructions R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/958e713f5e51acda9595e66ecc222734f21fe526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -4 lines) Patch
M runtime/vm/ast.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder_test.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 4 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 11 months ago (2016-01-12 19:26:09 UTC) #3
rmacnak
lgtm
4 years, 11 months ago (2016-01-12 20:48:53 UTC) #4
Cutch
4 years, 11 months ago (2016-01-12 20:52:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
958e713f5e51acda9595e66ecc222734f21fe526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698