Consolidate debug stubs

runtime/vm/stub_code_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
@@ skipping 1690 matching lines @@
 }
 
 
 // Megamorphic call is currently implemented as IC call but through a stub
 // that does not check/count function invocations.
 void StubCode::GenerateMegamorphicCallStub(Assembler* assembler) {
   GenerateNArgsCheckInlineCacheStub(assembler, 1);
 }
 
 
-// ECX: ICData
-void StubCode::GenerateBreakpointEqNullStub(Assembler* assembler) {
+// EDX, EXC: May contain arguments to runtime stub.
+void StubCode::GenerateBreakpointRuntimeStub(Assembler* assembler) {
   __ EnterStubFrame();
+  // Save runtime args.
   __ pushl(ECX);
-  __ CallRuntime(kBreakpointEqualNullHandlerRuntimeEntry);
+  __ pushl(EDX);
+  // Room for result. Debugger stub returns address of the
+  // unpatched runtime stub.
+  __ pushl(Immediate(0));

[siva, 2013/05/23 01:11:26]

const Immediate& raw_null =
Immediate(reinterpret_cast<intptr_t>(Object::null());
__ pushl(raw_null); // Room for result.

similar to how it is done in other stubs.

[hausner, 2013/05/23 18:32:12]

Done.

+  __ CallRuntime(kBreakpointRuntimeHandlerRuntimeEntry);
+  __ popl(EAX);  // Address of original stub.
+  __ popl(EDX);  // Restore arguments.
   __ popl(ECX);
   __ LeaveFrame();
-  __ jmp(&StubCode::EqualityWithNullArgLabel());
-}
-
-
-// EDX: Arguments descriptor array.
-void StubCode::GenerateBreakpointClosureStub(Assembler* assembler) {
-  __ EnterStubFrame();
-  __ pushl(EDX);  // Push arguments descriptor.
-  __ CallRuntime(kBreakpointClosureHandlerRuntimeEntry);
-  __ popl(EDX);  // Restore arguments descriptor.
-  __ LeaveFrame();
-  __ jmp(&StubCode::CallClosureFunctionLabel());
+  __ jmp(EAX);   // Jump to original stub.
 }
 
 
 // EDX: Arguments descriptor array.
 // TOS(0): return address (Dart code).
 void StubCode::GenerateBreakpointStaticStub(Assembler* assembler) {
   // Create a stub frame as we are pushing some objects on the stack before
   // calling into the runtime.
   __ EnterStubFrame();
   __ pushl(EDX);  // Preserve arguments descriptor.
   const Immediate& raw_null =
       Immediate(reinterpret_cast<intptr_t>(Object::null()));
   __ pushl(raw_null);  // Room for result.
   __ CallRuntime(kBreakpointStaticHandlerRuntimeEntry);
   __ popl(EAX);  // Code object.
   __ popl(EDX);  // Restore arguments descriptor.
   __ LeaveFrame();
 
   // Now call the static function. The breakpoint handler function
   // ensures that the call target is compiled.
+  // Note that we can't just jump to the CallStatic function stub
+  // here since that stub would patch the call site with the
+  // static function address.
   __ movl(ECX, FieldAddress(EAX, Code::instructions_offset()));
   __ addl(ECX, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
   __ jmp(ECX);
 }
 
 
 //  TOS(0): return address (Dart code).
 void StubCode::GenerateBreakpointReturnStub(Assembler* assembler) {
   // Create a stub frame as we are pushing some objects on the stack before
   // calling into the runtime.
@@ skipping 386 matching lines @@
   __ Bind(&done);
   __ popl(temp);
   __ popl(right);
   __ popl(left);
   __ ret();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32