Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: runtime/vm/intrinsifier.h

Issue 15743017: Adds a flag to the standalone vm to throw an exception on 53-bit integer overflow. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/intrinsifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier.h
===================================================================
--- runtime/vm/intrinsifier.h (revision 23635)
+++ runtime/vm/intrinsifier.h (working copy)
@@ -16,36 +16,6 @@
// When adding a new function for intrinsification add a 0 as fingerprint,
// build and run to get the correct fingerprint from the mismatch error.
#define CORE_LIB_INTRINSIC_LIST(V) \
- V(_IntegerImplementation, _addFromInteger, Integer_addFromInteger, 726019207)\
- V(_IntegerImplementation, +, Integer_add, 1768648592) \
- V(_IntegerImplementation, _subFromInteger, Integer_subFromInteger, 726019207)\
- V(_IntegerImplementation, -, Integer_sub, 1292467582) \
- V(_IntegerImplementation, _mulFromInteger, Integer_mulFromInteger, 726019207)\
- V(_IntegerImplementation, *, Integer_mul, 1853182047) \
- V(_IntegerImplementation, %, Integer_modulo, 1211518976) \
- V(_IntegerImplementation, remainder, Integer_remainder, 1131753683) \
- V(_IntegerImplementation, ~/, Integer_truncDivide, 142750059) \
- V(_IntegerImplementation, unary-, Integer_negate, 676633254) \
- V(_IntegerImplementation, _bitAndFromInteger, \
- Integer_bitAndFromInteger, 726019207) \
- V(_IntegerImplementation, &, Integer_bitAnd, 354347153) \
- V(_IntegerImplementation, _bitOrFromInteger, \
- Integer_bitOrFromInteger, 726019207) \
- V(_IntegerImplementation, |, Integer_bitOr, 875694946) \
- V(_IntegerImplementation, _bitXorFromInteger, \
- Integer_bitXorFromInteger, 726019207) \
- V(_IntegerImplementation, ^, Integer_bitXor, 282155459) \
- V(_IntegerImplementation, \
- _greaterThanFromInteger, \
- Integer_greaterThanFromInt, 79222670) \
- V(_IntegerImplementation, >, Integer_greaterThan, 462314913) \
- V(_IntegerImplementation, ==, Integer_equal, 1424765465) \
- V(_IntegerImplementation, _equalToInteger, Integer_equalToInteger, 79222670) \
- V(_IntegerImplementation, <, Integer_lessThan, 1424838471) \
- V(_IntegerImplementation, <=, Integer_lessEqualThan, 949016155) \
- V(_IntegerImplementation, >=, Integer_greaterEqualThan, 949045946) \
- V(_IntegerImplementation, <<, Integer_shl, 1195917829) \
- V(_IntegerImplementation, >>, Integer_sar, 1980227743) \
V(_Smi, ~, Smi_bitNegate, 882629793) \
V(_Double, >, Double_greaterThan, 301935359) \
V(_Double, >=, Double_greaterEqualThan, 1184528952) \
@@ -60,7 +30,6 @@
V(_Double, get:isNegative, Double_getIsNegative, 54462366) \
V(_Double, _mulFromInteger, Double_mulFromInteger, 704314034) \
V(_Double, .fromInteger, Double_fromInteger, 842078193) \
- V(_Double, toInt, Double_toInt, 362666636) \
V(_ObjectArray, ., ObjectArray_Allocate, 97987288) \
V(_ObjectArray, get:length, Array_getLength, 405297088) \
V(_ObjectArray, [], Array_getIndexed, 71937385) \
@@ -86,7 +55,40 @@
V(_OneByteString, _setAt, OneByteString_setAt, 342452817) \
V(_OneByteString, _allocate, OneByteString_allocate, 510754908) \
+#define CORE_INTEGER_LIB_INTRINSIC_LIST(V) \
+ V(_IntegerImplementation, _addFromInteger, Integer_addFromInteger, 726019207)\
+ V(_IntegerImplementation, +, Integer_add, 1768648592) \
+ V(_IntegerImplementation, _subFromInteger, Integer_subFromInteger, 726019207)\
+ V(_IntegerImplementation, -, Integer_sub, 1292467582) \
+ V(_IntegerImplementation, _mulFromInteger, Integer_mulFromInteger, 726019207)\
+ V(_IntegerImplementation, *, Integer_mul, 1853182047) \
+ V(_IntegerImplementation, %, Integer_modulo, 1211518976) \
+ V(_IntegerImplementation, remainder, Integer_remainder, 1131753683) \
+ V(_IntegerImplementation, ~/, Integer_truncDivide, 142750059) \
+ V(_IntegerImplementation, unary-, Integer_negate, 676633254) \
+ V(_IntegerImplementation, _bitAndFromInteger, \
+ Integer_bitAndFromInteger, 726019207) \
+ V(_IntegerImplementation, &, Integer_bitAnd, 354347153) \
+ V(_IntegerImplementation, _bitOrFromInteger, \
+ Integer_bitOrFromInteger, 726019207) \
+ V(_IntegerImplementation, |, Integer_bitOr, 875694946) \
+ V(_IntegerImplementation, _bitXorFromInteger, \
+ Integer_bitXorFromInteger, 726019207) \
+ V(_IntegerImplementation, ^, Integer_bitXor, 282155459) \
+ V(_IntegerImplementation, \
+ _greaterThanFromInteger, \
+ Integer_greaterThanFromInt, 79222670) \
+ V(_IntegerImplementation, >, Integer_greaterThan, 462314913) \
+ V(_IntegerImplementation, ==, Integer_equal, 1424765465) \
+ V(_IntegerImplementation, _equalToInteger, Integer_equalToInteger, 79222670) \
+ V(_IntegerImplementation, <, Integer_lessThan, 1424838471) \
+ V(_IntegerImplementation, <=, Integer_lessEqualThan, 949016155) \
+ V(_IntegerImplementation, >=, Integer_greaterEqualThan, 949045946) \
+ V(_IntegerImplementation, <<, Integer_shl, 1195917829) \
+ V(_IntegerImplementation, >>, Integer_sar, 1980227743) \
+ V(_Double, toInt, Double_toInt, 362666636)
+
#define MATH_LIB_INTRINSIC_LIST(V) \
V(::, sqrt, Math_sqrt, 1662640002) \
V(::, sin, Math_sin, 1273932041) \
@@ -142,6 +144,7 @@
static bool destination(Assembler* assembler);
CORE_LIB_INTRINSIC_LIST(DECLARE_FUNCTION)
+ CORE_INTEGER_LIB_INTRINSIC_LIST(DECLARE_FUNCTION)
MATH_LIB_INTRINSIC_LIST(DECLARE_FUNCTION)
TYPED_DATA_LIB_INTRINSIC_LIST(DECLARE_FUNCTION)
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/intrinsifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698