Issue 15743002: Add more escape tests to process_shell_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15743002: Add more escape tests to process_shell_test. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 7 months ago

Reviewers:
Søren Gjesse, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add more escape tests to process_shell_test. BUG=

Patch Set 1 #

Total comments: 4

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tests/standalone/io/process_shell_test.dart	View		1 chunk	+2 lines, -0 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

https://codereview.chromium.org/15743002/diff/1/tests/standalone/io/process_shell_test.dart File tests/standalone/io/process_shell_test.dart (right): https://codereview.chromium.org/15743002/diff/1/tests/standalone/io/process_shell_test.dart#newcode37 tests/standalone/io/process_shell_test.dart:37: test(["arg\\'"]); If you want to make sure that escaping ...

7 years, 7 months ago (2013-05-23 10:26:38 UTC) #3

Anders Johnsen

7 years, 7 months ago (2013-05-23 15:22:57 UTC) #4

Closing issue, see https://codereview.chromium.org/15883003/.

https://codereview.chromium.org/15743002/diff/1/tests/standalone/io/process_s...
File tests/standalone/io/process_shell_test.dart (right):

https://codereview.chromium.org/15743002/diff/1/tests/standalone/io/process_s...
tests/standalone/io/process_shell_test.dart:37: test(["arg\\'"]);
On 2013/05/23 10:26:38, kustermann wrote:
> If you want to make sure that escaping works correctly, you have to use more
> than one argument.

Done.

https://codereview.chromium.org/15743002/diff/1/tests/standalone/io/process_s...
tests/standalone/io/process_shell_test.dart:38: }
On 2013/05/23 10:26:38, kustermann wrote:
> I've one more question regarding the functionality of this. Should I be able
to
> determine the home directory like this?
> Process.runShell("echo", [r"$HOME"])

Please see https://codereview.chromium.org/15883003/.

Expand Messages | Collapse Messages