Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

Issue 1574283002: GIF Animations "clear from cache related glitch" fix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: @pkasting, great that you figured out this - yes, DisposeOverwritePrevious fixes this. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h
diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h
index 3ce2da9d3bbc71324c81ccc2e0559ece8a61b519..bf817f80be8d93efe2fd4114e7e6bda094219dc4 100644
--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h
+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h
@@ -80,6 +80,9 @@ private:
// the previous frame's disposal method. Returns true on success. On
// failure, this will mark the image as failed.
bool initFrameBuffer(size_t frameIndex);
+ // If disposal method is DisposeOverwritePrevious, keep two frames: current
Peter Kasting 2016/01/14 00:17:29 Nit: Blank line above this
aleksandar.stojiljkovic 2016/01/14 11:32:53 Done.
+ // and it's required previous frame.
Peter Kasting 2016/01/14 00:17:29 This comment is technically a bit of a layering vi
aleksandar.stojiljkovic 2016/01/14 11:32:53 Done.
+ size_t clearCacheExceptTwoFrames(size_t dontClearFrame1, size_t dontClearFrame2);
bool m_currentBufferSawAlpha;
mutable int m_repetitionCount;

Powered by Google App Engine
This is Rietveld 408576698