third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h - Issue 1574283002: GIF Animations "clear from cache related glitch" fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

Issue 1574283002: GIF Animations "clear from cache related glitch" fix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more correct way to write it. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

index 3ce2da9d3bbc71324c81ccc2e0559ece8a61b519..d1f043a80819efef288f2ae9e2e38b9a2f01425b 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

@@ -81,6 +81,9 @@ private:

// failure, this will mark the image as failed.

bool initFrameBuffer(size_t frameIndex);

+ // Like clearCacheExceptFrame(), but preserves two frames instead of one.

+ size_t clearCacheExceptTwoFrames(size_t dontClearFrame1, size_t dontClearFrame2);

Peter Kasting 2016/01/14 22:58:39 Nit: For maximum parallelism with clearCacheExcept

bool m_currentBufferSawAlpha;

mutable int m_repetitionCount;

OwnPtr<GIFImageReader> m_reader;