Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4524)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPromoView.java

Issue 1574273002: Unify and Improve the Sign-In and Sync Confirmation Screens on Clank. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPromoView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPromoView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPromoView.java
index 946b28ac1b4b89ee4364c6b8d45dddc84b964593..99039a30fb434c0dd71db102fe4f5b7fa312c777 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPromoView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPromoView.java
@@ -245,14 +245,8 @@ public class RecentTabsPromoView extends FrameLayout implements AndroidSyncSetti
signInPromoView.getLayoutParams().height = LayoutParams.WRAP_CONTENT;
((FrameLayout.LayoutParams) signInPromoView.getLayoutParams()).gravity = Gravity.CENTER;
signInPromoView.configureForRecentTabsPage();
- signInPromoView.setCanCancel(false);
signInPromoView.setListener(new AccountFirstRunView.Listener() {
- @Override
- public void onAccountSelectionConfirmed(String accountName) {
- if (mUserActionListener != null) mUserActionListener.onAccountSelectionConfirmed();
-
- ConfirmAccountChangeFragment.confirmSyncAccount(accountName, mActivity);
- }
+ private String mAccountName;
@Override
public void onAccountSelectionCanceled() {
@@ -267,12 +261,19 @@ public class RecentTabsPromoView extends FrameLayout implements AndroidSyncSetti
}
@Override
- public void onSigningInCompleted(String accountName) {
- assert false : "Button should be hidden";
+ public void onSignIn(String accountName) {
+ mAccountName = accountName;
+ }
+
+ @Override
+ public void onDoneClicked() {
+ if (mUserActionListener != null) mUserActionListener.onAccountSelectionConfirmed();
+
+ ConfirmAccountChangeFragment.confirmSyncAccount(mAccountName, mActivity);
}
@Override
- public void onSettingsButtonClicked(String accountName) {
+ public void onSettingsClicked() {
assert false : "Button should be hidden";
}

Powered by Google App Engine
This is Rietveld 408576698