Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3776)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

Issue 1574273002: Unify and Improve the Sign-In and Sync Confirmation Screens on Clank. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
index c598cfa288f9a462b8a20d1bd1455f823250fc8e..54bff394663a03fa3bc848dcdf84dbe3b3be594d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
@@ -5,7 +5,9 @@
package org.chromium.chrome.browser.ntp;
import android.content.Context;
+import android.content.SharedPreferences;
import android.graphics.Bitmap;
+import android.preference.PreferenceManager;
import org.chromium.base.ObserverList;
import org.chromium.base.ThreadUtils;
@@ -52,6 +54,8 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
}
private static final int RECENTLY_CLOSED_MAX_TAB_COUNT = 5;
+ private static final String PREF_SIGNIN_PROMO_DECLINED =
+ "recent_tabs_signin_promo_declined";
private final Profile mProfile;
private final Tab mTab;
@@ -386,10 +390,25 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
return false;
}
+ if (PreferenceManager.getDefaultSharedPreferences(mContext).getBoolean(
+ PREF_SIGNIN_PROMO_DECLINED, false)) {
+ return false;
+ }
+
return !AndroidSyncSettings.isSyncEnabled(mContext) || mForeignSessions.isEmpty();
}
/**
+ * Save that user tapped "No" button on the signin promo.
+ */
+ public void setSigninPromoDeclined() {
+ SharedPreferences.Editor sharedPreferencesEditor =
+ PreferenceManager.getDefaultSharedPreferences(mContext).edit();
+ sharedPreferencesEditor.putBoolean(PREF_SIGNIN_PROMO_DECLINED, true);
+ sharedPreferencesEditor.apply();
+ }
+
+ /**
* Collapse the sync promo.
*
* @param isCollapsed Whether the sync promo is collapsed.

Powered by Google App Engine
This is Rietveld 408576698