chrome/browser/android/profiles/profile_downloader_android.cc - Issue 1574273002: Unify and Improve the Sign-In and Sync Confirmation Screens on Clank.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/profiles/profile_downloader_android.cc

Issue 1574273002: Unify and Improve the Sign-In and Sync Confirmation Screens on Clank. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunView.java ('K') | « chrome/android/java/strings/android_chrome_strings.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/profiles/profile_downloader_android.cc

diff --git a/chrome/browser/android/profiles/profile_downloader_android.cc b/chrome/browser/android/profiles/profile_downloader_android.cc

index 635689d702cb825af1d8e467b79e72d26467cef2..b756026527777f1d918d0b6e51f4d85992eaee36 100644

--- a/chrome/browser/android/profiles/profile_downloader_android.cc

+++ b/chrome/browser/android/profiles/profile_downloader_android.cc

@@ -193,6 +193,14 @@ void StartFetchingAccountInfoFor(JNIEnv* env,

AccountTrackerService* account_tracker_service =

AccountTrackerServiceFactory::GetForProfile(profile);

+ AccountInfo account_info =

+ account_tracker_service->FindAccountInfoByEmail(email);

+ if (account_info.account_id.empty()) {

+ LOG(ERROR) << "Could not get valid account information for " << email;

newt (away) 2016/02/11 16:46:06 I believe we shouldn't log email addresses. I'd re

PEConn 2016/02/12 18:41:20 Done.

+ return;

+ }

AccountInfoRetriever* retriever = new AccountInfoRetriever(

profile,

account_tracker_service->FindAccountInfoByEmail(email).account_id, email,