Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkSigninActivity.java

Issue 1574273002: Unify and Improve the Sign-In and Sync Confirmation Screens on Clank. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkSigninActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkSigninActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkSigninActivity.java
index 7912bd04be9036c9c84145a6a094c644c4a8c059..d759b5123260c5627fc0ecdbe05505aa97c56334 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkSigninActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkSigninActivity.java
@@ -130,6 +130,13 @@ public class EnhancedBookmarkSigninActivity extends EnhancedBookmarkActivityBase
}
@Override
+ public void onAccountSelectionCancelled() {
+ RecordUserAction.record("Stars_SignInPromoActivity_Cancel");
newt (away) 2016/02/09 23:08:12 Where did these metrics come from? Are they docume
PEConn 2016/02/11 14:44:55 I'm removing this to put in separate CL for crbug.
+ RecordUserAction.record("Signin_Cancel_FromBookmarkManager");
+ finish();
+ };
+
+ @Override
public ProfileDataCache getProfileDataCache() {
if (mProfileDataCache == null) {
mProfileDataCache = new ProfileDataCache(this, Profile.getLastUsedProfile());

Powered by Google App Engine
This is Rietveld 408576698