Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1574263002: [wasm] Fix empty asm.js function in ASM->WASM. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix empty asm.js function in ASM->WASM. R=ahaas@chromium.org BUG= Committed: https://crrev.com/d672ee30c9424670fe950ca6595d7c5438a52f20 Cr-Commit-Position: refs/heads/master@{#33238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -22 lines) Patch
M src/wasm/encoder.cc View 3 chunks +26 lines, -22 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 11 months ago (2016-01-12 13:06:29 UTC) #1
ahaas
lgtm
4 years, 11 months ago (2016-01-12 13:30:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574263002/1
4 years, 11 months ago (2016-01-12 13:32:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 13:34:00 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 13:34:25 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d672ee30c9424670fe950ca6595d7c5438a52f20
Cr-Commit-Position: refs/heads/master@{#33238}

Powered by Google App Engine
This is Rietveld 408576698