Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Unified Diff: Source/web/WebMediaPlayerClientImpl.h

Issue 157423003: Remove the dependency on encryptedmedia from HTMLMediaElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address review comments. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebMediaPlayerClientImpl.h
diff --git a/Source/web/WebMediaPlayerClientImpl.h b/Source/web/WebMediaPlayerClientImpl.h
index 91cd9d734feed7ede44fdbf9f56597e2f2b5e971..38f5b78c3586e0865b939d51053dc940eb80a563 100644
--- a/Source/web/WebMediaPlayerClientImpl.h
+++ b/Source/web/WebMediaPlayerClientImpl.h
@@ -48,6 +48,7 @@
namespace WebCore {
class AudioSourceProviderClient;
+class HTMLMediaElement;
}
namespace blink {
@@ -67,9 +68,6 @@ public:
virtual ~WebMediaPlayerClientImpl();
- // Returns the encapsulated blink::WebMediaPlayer.
- WebMediaPlayer* mediaPlayer() const;
-
// WebMediaPlayerClient methods:
virtual void networkStateChanged() OVERRIDE;
virtual void readyStateChanged() OVERRIDE;
@@ -81,12 +79,16 @@ public:
virtual double volume() const OVERRIDE;
virtual void playbackStateChanged() OVERRIDE;
virtual WebMediaPlayer::Preload preload() const OVERRIDE;
+
+ // WebEncryptedMediaPlayerClient methods:
+ // FIXME: Remove these once the WebMediaPlayer implementation stop making these calls on the WebMediaPlayerClient object.
ddorwin 2014/02/27 00:37:59 Where should it be making them?
acolwell GONE FROM CHROMIUM 2014/02/27 01:11:11 This was left over from the original patch I sent
c.shu 2014/02/27 14:49:46 Done.
virtual void keyAdded(const WebString& keySystem, const WebString& sessionId) OVERRIDE;
virtual void keyError(const WebString& keySystem, const WebString& sessionId, MediaKeyErrorCode, unsigned short systemCode) OVERRIDE;
virtual void keyMessage(const WebString& keySystem, const WebString& sessionId, const unsigned char* message, unsigned messageLength, const WebURL& defaultURL) OVERRIDE;
virtual void keyNeeded(const WebString& contentType, const unsigned char* initData, unsigned initDataLength) OVERRIDE;
virtual WebPlugin* createHelperPlugin(const WebString& pluginType, WebFrame*) OVERRIDE;
virtual void closeHelperPluginSoon(WebFrame*) OVERRIDE;
+
virtual bool needsWebLayerForVideo() const OVERRIDE;
virtual void setWebLayer(WebLayer*) OVERRIDE;
virtual void addTextTrack(WebInbandTextTrack*) OVERRIDE;
@@ -96,8 +98,8 @@ public:
virtual void requestSeek(double) OVERRIDE;
// MediaPlayer methods:
+ virtual WebMediaPlayer* webMediaPlayer() const OVERRIDE;
virtual void load(WebMediaPlayer::LoadType, const WTF::String& url) OVERRIDE;
-
virtual void play() OVERRIDE;
virtual void pause() OVERRIDE;
virtual void prepareToPlay() OVERRIDE;
@@ -139,17 +141,14 @@ public:
virtual WebCore::AudioSourceProvider* audioSourceProvider() OVERRIDE;
#endif
- virtual WebCore::MediaPlayer::MediaKeyException generateKeyRequest(const String& keySystem, const unsigned char* initData, unsigned initDataLength) OVERRIDE;
- virtual WebCore::MediaPlayer::MediaKeyException addKey(const String& keySystem, const unsigned char* key, unsigned keyLength, const unsigned char* initData, unsigned initDataLength, const String& sessionId) OVERRIDE;
- virtual WebCore::MediaPlayer::MediaKeyException cancelKeyRequest(const String& keySystem, const String& sessionId) OVERRIDE;
- virtual void setContentDecryptionModule(WebContentDecryptionModule*) OVERRIDE;
-
private:
explicit WebMediaPlayerClientImpl(WebCore::MediaPlayerClient*);
void startDelayedLoad();
void loadInternal();
+ WebCore::HTMLMediaElement& mediaElement() const;
+
#if OS(ANDROID)
// FIXME: This path "only works" on Android. It is a workaround for the problem that Skia could not handle Android's GL_TEXTURE_EXTERNAL_OES
// texture internally. It should be removed and replaced by the normal paint path.
@@ -168,7 +167,6 @@ private:
double m_volume;
bool m_muted;
double m_rate;
- WebContentDecryptionModule* m_cdm;
#if ENABLE(WEB_AUDIO)
// AudioClientImpl wraps an AudioSourceProviderClient.

Powered by Google App Engine
This is Rietveld 408576698