Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1574223002: Revert of [builtins] Refactor the remaining Date builtins. (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Refactor the remaining Date builtins. (patchset #2 id:20001 of https://codereview.chromium.org/1579613002/ ) Reason for revert: [Sheriff] Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/5711 Original issue's description: > [builtins] Refactor the remaining Date builtins. > > This migrates the remaining Date builtins to C++ and removes obsolete > intrinsics and JavaScript wrappers. This reduces the overhead imposed > by the Date builtins, and will allow us to optimize them later in the > TurboFan compiler, while the interpreter doesn't need to worry about > them. > > R=yangguo@chromium.org > BUG=chromium:576574 > LOG=n > > Committed: https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281 > Cr-Commit-Position: refs/heads/master@{#33228} TBR=yangguo@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:576574 Committed: https://crrev.com/405ee3aad5add8c1d70491e633b585a4238ff516 Cr-Commit-Position: refs/heads/master@{#33230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1772 lines, -724 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +78 lines, -122 lines 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -21 lines 0 comments Download
M src/builtins.cc View 4 chunks +15 lines, -545 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 4 chunks +40 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 2 chunks +20 lines, -0 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +22 lines, -0 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +20 lines, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +20 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +20 lines, -0 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +22 lines, -0 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A src/js/date.js View 1 chunk +547 lines, -0 lines 0 comments Download
M src/js/json.js View 2 chunks +0 lines, -19 lines 0 comments Download
M src/js/macros.py View 2 chunks +64 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/runtime/runtime-date.cc View 3 chunks +95 lines, -1 line 0 comments Download
M test/cctest/test-date.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/messages.js View 2 chunks +6 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-1945.js View 1 chunk +34 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of [builtins] Refactor the remaining Date builtins.
4 years, 11 months ago (2016-01-12 10:13:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574223002/1
4 years, 11 months ago (2016-01-12 10:14:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 10:14:29 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 10:15:33 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/405ee3aad5add8c1d70491e633b585a4238ff516
Cr-Commit-Position: refs/heads/master@{#33230}

Powered by Google App Engine
This is Rietveld 408576698