Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 1574213006: DevTools: beautified styles sidebar toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 * @override 84 * @override
85 * @return {!Array<!WebInspector.ToolbarItem>} 85 * @return {!Array<!WebInspector.ToolbarItem>}
86 */ 86 */
87 toolbarItems: function() 87 toolbarItems: function()
88 { 88 {
89 var result = WebInspector.UISourceCodeFrame.prototype.toolbarItems.call( this); 89 var result = WebInspector.UISourceCodeFrame.prototype.toolbarItems.call( this);
90 var originURL = WebInspector.CompilerScriptMapping.uiSourceCodeOrigin(th is.uiSourceCode()); 90 var originURL = WebInspector.CompilerScriptMapping.uiSourceCodeOrigin(th is.uiSourceCode());
91 if (originURL) { 91 if (originURL) {
92 var parsedURL = originURL.asParsedURL(); 92 var parsedURL = originURL.asParsedURL();
93 if (parsedURL) 93 if (parsedURL)
94 result.push(new WebInspector.ToolbarLabel(WebInspector.UIString( "(source mapped from %s)", parsedURL.displayName))); 94 result.push(new WebInspector.ToolbarText(WebInspector.UIString(" (source mapped from %s)", parsedURL.displayName)));
95 } 95 }
96 return result; 96 return result;
97 }, 97 },
98 98
99 _updateInfobars: function() 99 _updateInfobars: function()
100 { 100 {
101 this.attachInfobars([this._blackboxInfobar, this._divergedInfobar]); 101 this.attachInfobars([this._blackboxInfobar, this._divergedInfobar]);
102 }, 102 },
103 103
104 _showDivergedInfobar: function() 104 _showDivergedInfobar: function()
(...skipping 1007 matching lines...) Expand 10 before | Expand all | Expand 10 after
1112 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyChanged, this._workingCopyChanged, this); 1112 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyChanged, this._workingCopyChanged, this);
1113 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyCommitted, this._workingCopyCommitted, this); 1113 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyCommitted, this._workingCopyCommitted, this);
1114 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .TitleChanged, this._showBlackboxInfobarIfNeeded, this); 1114 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .TitleChanged, this._showBlackboxInfobarIfNeeded, this);
1115 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this); 1115 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this);
1116 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this); 1116 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this);
1117 WebInspector.UISourceCodeFrame.prototype.dispose.call(this); 1117 WebInspector.UISourceCodeFrame.prototype.dispose.call(this);
1118 }, 1118 },
1119 1119
1120 __proto__: WebInspector.UISourceCodeFrame.prototype 1120 __proto__: WebInspector.UISourceCodeFrame.prototype
1121 } 1121 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698