Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 1574213006: DevTools: beautified styles sidebar toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 142
143 this._filterSelect = new WebInspector.ToolbarComboBox(this._changeFilter.bin d(this)); 143 this._filterSelect = new WebInspector.ToolbarComboBox(this._changeFilter.bin d(this));
144 this._filterSelect.setVisible(false); 144 this._filterSelect.setVisible(false);
145 this._updateFilterOptions(); 145 this._updateFilterOptions();
146 146
147 this._classNameFilter = new WebInspector.ToolbarInput("Class filter"); 147 this._classNameFilter = new WebInspector.ToolbarInput("Class filter");
148 this._classNameFilter.setVisible(false); 148 this._classNameFilter.setVisible(false);
149 this._constructorsDataGrid.setNameFilter(this._classNameFilter); 149 this._constructorsDataGrid.setNameFilter(this._classNameFilter);
150 this._diffDataGrid.setNameFilter(this._classNameFilter); 150 this._diffDataGrid.setNameFilter(this._classNameFilter);
151 151
152 this._selectedSizeText = new WebInspector.ToolbarLabel(); 152 this._selectedSizeText = new WebInspector.ToolbarText();
153 153
154 this._popoverHelper = new WebInspector.ObjectPopoverHelper(this.element, thi s._getHoverAnchor.bind(this), this._resolveObjectForPopover.bind(this), undefine d, true); 154 this._popoverHelper = new WebInspector.ObjectPopoverHelper(this.element, thi s._getHoverAnchor.bind(this), this._resolveObjectForPopover.bind(this), undefine d, true);
155 155
156 this._currentPerspectiveIndex = 0; 156 this._currentPerspectiveIndex = 0;
157 this._currentPerspective = this._perspectives[0]; 157 this._currentPerspective = this._perspectives[0];
158 this._currentPerspective.activate(this); 158 this._currentPerspective.activate(this);
159 this._dataGrid = this._currentPerspective.masterGrid(this); 159 this._dataGrid = this._currentPerspective.masterGrid(this);
160 160
161 this._populate(); 161 this._populate();
162 this._searchThrottler = new WebInspector.Throttler(0); 162 this._searchThrottler = new WebInspector.Throttler(0);
(...skipping 2086 matching lines...) Expand 10 before | Expand all | Expand 10 after
2249 name.textContent = WebInspector.beautifyFunctionName(frame.functionN ame); 2249 name.textContent = WebInspector.beautifyFunctionName(frame.functionN ame);
2250 if (frame.scriptId) { 2250 if (frame.scriptId) {
2251 var urlElement = this._linkifier.linkifyScriptLocation(this._tar get, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1) ; 2251 var urlElement = this._linkifier.linkifyScriptLocation(this._tar get, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1) ;
2252 frameDiv.appendChild(urlElement); 2252 frameDiv.appendChild(urlElement);
2253 } 2253 }
2254 } 2254 }
2255 }, 2255 },
2256 2256
2257 __proto__: WebInspector.Widget.prototype 2257 __proto__: WebInspector.Widget.prototype
2258 } 2258 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698