Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: runtime/vm/object.cc

Issue 1574213005: Report missing semicolons after function declarations (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 730d5605b16b7a2f2cfa1bd21d8272a3950a61e1..5ac9aba9b8e8ef6cb501524daf38346c474c3e85 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -2049,6 +2049,7 @@ static void ReportTooManyTypeArguments(const Class& cls) {
Report::MessageF(Report::kError,
Script::Handle(cls.script()),
cls.token_pos(),
+ Report::AtLocation,
"too many type parameters declared in class '%s' or in its "
"super classes",
String::Handle(cls.Name()).ToCString());
@@ -2898,6 +2899,7 @@ bool Class::ApplyPatch(const Class& patch, Error* error) const {
*error, // No previous error.
Script::Handle(patch.script()),
func.token_pos(),
+ Report::AtLocation,
Report::kError,
Heap::kNew,
"signature mismatch: '%s'", member_name.ToCString());
@@ -2943,6 +2945,7 @@ bool Class::ApplyPatch(const Class& patch, Error* error) const {
*error, // No previous error.
Script::Handle(patch.script()),
field.token_pos(),
+ Report::AtLocation,
Report::kError,
Heap::kNew,
"duplicate field: %s", member_name.ToCString());
@@ -6169,6 +6172,7 @@ bool Function::HasCompatibleParametersWith(const Function& other,
*bound_error, // A bound error if non null.
Script::Handle(other.script()),
other.token_pos(),
+ Report::AtLocation,
Report::kError,
Heap::kNew,
"signature type '%s' of function '%s' is not a subtype of signature "
@@ -9240,6 +9244,7 @@ static void ReportTooManyImports(const Library& lib) {
Report::MessageF(Report::kError,
Script::Handle(lib.LookupScript(url)),
Scanner::kNoSourcePos,
+ Report::AtLocation,
"too many imports in library '%s'",
url.ToCString());
UNREACHABLE();
@@ -14503,6 +14508,7 @@ RawLanguageError* LanguageError::New() {
RawLanguageError* LanguageError::NewFormattedV(const Error& prev_error,
const Script& script,
intptr_t token_pos,
+ bool report_after_token,
Report::Kind kind,
Heap::Space space,
const char* format,
@@ -14519,6 +14525,7 @@ RawLanguageError* LanguageError::NewFormattedV(const Error& prev_error,
result.set_previous_error(prev_error);
result.set_script(script);
result.set_token_pos(token_pos);
+ result.set_report_after_token(report_after_token);
result.set_kind(kind);
result.set_message(String::Handle(
String::NewFormattedV(format, args, space)));
@@ -14529,13 +14536,15 @@ RawLanguageError* LanguageError::NewFormattedV(const Error& prev_error,
RawLanguageError* LanguageError::NewFormatted(const Error& prev_error,
const Script& script,
intptr_t token_pos,
+ bool report_after_token,
Report::Kind kind,
Heap::Space space,
const char* format, ...) {
va_list args;
va_start(args, format);
RawLanguageError* result = LanguageError::NewFormattedV(
- prev_error, script, token_pos, kind, space, format, args);
+ prev_error, script, token_pos, report_after_token,
+ kind, space, format, args);
NoSafepointScope no_safepoint;
va_end(args);
return result;
@@ -14576,6 +14585,11 @@ void LanguageError::set_token_pos(intptr_t token_pos) const {
}
+void LanguageError::set_report_after_token(bool value) {
+ StoreNonPointer(&raw_ptr()->report_after_token_, value);
+}
+
+
void LanguageError::set_kind(uint8_t value) const {
StoreNonPointer(&raw_ptr()->kind_, value);
}
@@ -14599,6 +14613,7 @@ RawString* LanguageError::FormatMessage() const {
Report::PrependSnippet(kind(),
Script::Handle(script()),
token_pos(),
+ report_after_token(),
String::Handle(message())));
// Prepend previous error message.
const Error& prev_error = Error::Handle(previous_error());
@@ -16747,6 +16762,7 @@ bool TypeParameter::CheckBound(const AbstractType& bounded_type,
*bound_error,
script,
token_pos(),
+ Report::AtLocation,
Report::kMalboundedType,
Heap::kNew,
"type parameter '%s' of class '%s' must extend bound '%s', "
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698