Report missing semicolons after function declarations

Report missing semicolons after function declarations

Also take the opportunity to add the ability to report an error after a given token position. This way, the missing semicolon gets reported where it should: at the end of the line rather than the first token on the following line, when the error is actually detected.

BUG=23761
R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/782f7b268bda32e907714492ac50b706493027d3

[hausner, 2016-01-13 21:05:59]

Description was changed from

==========
wip


Report missing semicolons after function declarations

BUG=
==========

to

==========
Report missing semicolons after function declarations

BUG= 23761
==========

[hausner, 2016-01-13 21:14:03]

hausner@google.com changed reviewers:
+ regis@google.com

[hausner, 2016-01-13 21:16:57]

I am not terribly happy about the naming of the new parameters. I want to
express that an error gets reported at the end of a token rather than at the
beginning of it. Let me know if you have a better idea.

[regis, 2016-01-13 21:57:11]

lgtm

You could maybe declare 2 boolean constants in Token class:
Token::kPointAt (=false)
Token::kPointAfter (=true)
And use them instead of true and false.
The field could be point_after_

or
Token::kReportAt
Token::kReportAfter
report_after_

[hausner, 2016-01-13 22:51:13]

Description was changed from

==========
Report missing semicolons after function declarations

BUG= 23761
==========

to

==========
Report missing semicolons after function declarations

Also take the opportunity to add the ability to report an error after a given
token position. This way, the missing semicolon gets reported where it should:
at the end of the line rather than the first token on the following line, when
the error is actually detected.

BUG= 23761
==========

[hausner, 2016-01-19 17:31:37]

Description was changed from

==========
Report missing semicolons after function declarations

Also take the opportunity to add the ability to report an error after a given
token position. This way, the missing semicolon gets reported where it should:
at the end of the line rather than the first token on the following line, when
the error is actually detected.

BUG= 23761
==========

to

==========
Report missing semicolons after function declarations

Also take the opportunity to add the ability to report an error after a given
token position. This way, the missing semicolon gets reported where it should:
at the end of the line rather than the first token on the following line, when
the error is actually detected.

BUG= 23761
R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/782f7b268bda32e907714492ac50b706493027d3
==========

[hausner, 2016-01-19 17:31:38]

Committed patchset #3 (id:40001) manually as
782f7b268bda32e907714492ac50b706493027d3 (presubmit successful).