Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 15742020: Revert 202508 "Made the open menu item in the context menu updat..." (Closed)

Created:
7 years, 6 months ago by Nikita (slow)
Modified:
7 years, 6 months ago
Reviewers:
hirono
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 202508 "Made the open menu item in the context menu updat..." Breaks CrOS test: SelectFileDialogExtensionBrowserTest.SelectFileAndOpen http://goo.gl/eoUBv http://goo.gl/uzb7V > Made the open menu item in the context menu updated when the context menu is open. > > Originally, FileSelectionHandler#updateFileSelectionAsync have the complex > conditional statements. And when util.platform.newUI() is true and > selection.totalCount is zero, updateContextMenuActionItems that updates the open > menu item is not called. > > This CL arranged the statements by the target of update and added some comments. > > BUG=243687 > TEST=manually > > Review URL: https://chromiumcodereview.appspot.com/15950003 TBR=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -44 lines) Patch
M trunk/src/chrome/browser/resources/file_manager/js/file_selection.js View 1 chunk +52 lines, -44 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nikita (slow)
7 years, 6 months ago (2013-05-28 10:10:42 UTC) #1
Nikita (slow)
Committed patchset #1 manually as r202522.
7 years, 6 months ago (2013-05-28 10:10:56 UTC) #2
Nikita (slow)
7 years, 6 months ago (2013-05-28 10:12:46 UTC) #3
Message was sent while issue was closed.
Consistently fails on
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...

Often fails on
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

[29085:29085:0528/010810:1071884224:INFO:select_file_dialog_extension_browsertest.cc(165)]
Waiting for JavaScript selection-change-complete message.
[29085:29085:0528/010810:1071899424:INFO:select_file_dialog_extension_browsertest.cc(210)]
Waiting for window close notification.
[29085:29085:0528/010810:1071900272:INFO:CONSOLE(1)] "Test JavaScript
injected.", source:  (1)
../../chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc:214:
Failure
Value of: dialog_->IsRunning(owning_window)
Actual: true
Expected: false
../../chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc:293:
Failure
Value of: listener_->file_selected()
Actual: false
Expected: true

Powered by Google App Engine
This is Rietveld 408576698