Avoid DidStopLoading messages from the old renderer process during a transfer.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 5443 matching lines @@
 void RenderViewImpl::OnShouldClose() {
   base::TimeTicks before_unload_start_time = base::TimeTicks::Now();
   bool should_close = webview()->dispatchBeforeUnloadEvent();
   base::TimeTicks before_unload_end_time = base::TimeTicks::Now();
   Send(new ViewHostMsg_ShouldClose_ACK(routing_id_, should_close,
                                        before_unload_start_time,
                                        before_unload_end_time));
 }
 
 void RenderViewImpl::OnSwapOut(const ViewMsg_SwapOut_Params& params) {
-  // Ensure that no other in-progress navigation continues.
-  OnStop();
-
   // Only run unload if we're not swapped out yet, but send the ack either way.
   if (!is_swapped_out_) {
     // Swap this RenderView out so the tab can navigate to a page rendered by a
     // different process.  This involves running the unload handler and clearing
     // the page.  Once WasSwappedOut is called, we also allow this process to
     // exit if there are no other active RenderViews in it.
 
     // Send an UpdateState message before we get swapped out.
     SyncNavigationState();
 
     // Synchronously run the unload handler before sending the ACK.
     webview()->dispatchUnloadEvent();
 
     // Swap out and stop sending any IPC messages that are not ACKs.
     SetSwappedOut(true);
 
+    // Ensure that no other in-progress navigation continues, once we've started
+    // filtering the IPCs.  We don't want to send a DidStopLoading for this.

[Matt Perry, 2013/05/28 22:08:06]

Not sure I understand the comment. What does "this" refer to? OnStop sends a
DidStopLoading, doesn't it?

[Charlie Reis, 2013/05/28 22:17:02]

The SetSwappedOut line above it starts filtering out IPC messages, including
DidStopLoading.  The browser process used to hear DidStopLoading when the OnStop
call was before we started filtering, and it doesn't hear it anymore.

+    OnStop();
+
     // Replace the page with a blank dummy URL. The unload handler will not be
     // run a second time, thanks to a check in FrameLoader::stopLoading.
     // TODO(creis): Need to add a better way to do this that avoids running the
     // beforeunload handler. For now, we just run it a second time silently.
     NavigateToSwappedOutURL(webview()->mainFrame());
 
     // Let WebKit know that this view is hidden so it can drop resources and
     // stop compositing.
     webview()->setVisibilityState(WebKit::WebPageVisibilityStateHidden, false);
   }
@@ skipping 1069 matching lines @@
     WebURL url = icon_urls[i].iconURL();
     if (!url.isEmpty())
       urls.push_back(FaviconURL(url,
                                 ToFaviconType(icon_urls[i].iconType())));
   }
   SendUpdateFaviconURL(urls);
 }
 
 
 }  // namespace content