Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Issue 15742013: overscroll: Do not overscroll if the beginning of a scroll was consumed. (Closed)

Created:
7 years, 7 months ago by sadrul
Modified:
7 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

overscroll: Do not overscroll if the beginning of a scroll was consumed. If the start of a scroll gesture scrolls the actual content on the page, then that scroll-sequence should not do overscroll, even if the page runs out of scrollable content, until the user restarts the scroll sequence (by lifting fingers from the touchpad/touchscreen). BUG=179484 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201676

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -13 lines) Patch
M content/browser/renderer_host/overscroll_controller.h View 2 chunks +15 lines, -0 lines 0 comments Download
M content/browser/renderer_host/overscroll_controller.cc View 1 6 chunks +40 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 4 chunks +102 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
7 years, 7 months ago (2013-05-22 23:01:52 UTC) #1
sky
LGTM https://codereview.chromium.org/15742013/diff/1/content/browser/renderer_host/overscroll_controller.cc File content/browser/renderer_host/overscroll_controller.cc (right): https://codereview.chromium.org/15742013/diff/1/content/browser/renderer_host/overscroll_controller.cc#newcode106 content/browser/renderer_host/overscroll_controller.cc:106: if (scroll_state_ == STATE_UNKNOWN) { nit: combine this ...
7 years, 7 months ago (2013-05-23 00:07:49 UTC) #2
sadrul
https://codereview.chromium.org/15742013/diff/1/content/browser/renderer_host/overscroll_controller.cc File content/browser/renderer_host/overscroll_controller.cc (right): https://codereview.chromium.org/15742013/diff/1/content/browser/renderer_host/overscroll_controller.cc#newcode106 content/browser/renderer_host/overscroll_controller.cc:106: if (scroll_state_ == STATE_UNKNOWN) { On 2013/05/23 00:07:49, sky ...
7 years, 7 months ago (2013-05-23 02:01:35 UTC) #3
sadrul
7 years, 7 months ago (2013-05-23 04:11:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r201676 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698