Update browser controller and unittest lib to use start marker to figure out when to start new test…

pkg/unittest/lib/test_controller.js

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Test controller logic - used by unit test harness to embed tests in
  * DumpRenderTree.
  */
 
 // Clear the console before every test run - this is Firebug specific code.
@@ skipping 15 matching lines @@
 if (navigator.webkitStartDart) {
   navigator.webkitStartDart();
 }
 
 // testRunner is provided by DRT or WebKit's layout tests.
 // It is not available in selenium tests.
 var testRunner = window.testRunner || window.layoutTestController;
 
 var waitForDone = false;
 
-function sendDomToTestDriver() {
+function start() {

[kustermann, 2013/05/22 17:08:50]

For symmetry reasons, I'd call it 'notifyStart()'.

[ricow1, 2013/05/22 17:36:12]

Done.

+  if (testRunner) testRunner.startedDartTest = true;
+  if (window.opener) {
+    window.opener.postMessage("STARTING", "*");
+  }
+}
+
+function notifyDone() {
+  if (testRunner) testRunner.notifyDone();
+  // To support in browser launching of tests we post back start and result
+  // messages to the window.opener.
   if (window.opener) {
     window.opener.postMessage(window.document.body.innerHTML, "*");
   }
 }
 
 function processMessage(msg) {
   if (typeof msg != 'string') return;
   if (msg == 'unittest-suite-done') {
-    if (testRunner) testRunner.notifyDone();
-    sendDomToTestDriver();
+    notifyDone();
   } else if (msg == 'unittest-suite-wait-for-done') {
     waitForDone = true;
-    if (testRunner) testRunner.startedDartTest = true;
+    start();
   } else if (msg == 'dart-calling-main') {
-    if (testRunner) testRunner.startedDartTest = true;
+    start();

[kustermann, 2013/05/22 17:08:50]

When we reach this point, the test has already been executed. See on the line
150.
Please send the start message before calling main().

[ricow1, 2013/05/22 17:36:12]

That is fine, we do 2 postmessage there, they will queue up

   } else if (msg == 'dart-main-done') {
     if (!waitForDone) {
       window.postMessage('unittest-suite-success', '*');
     }
   } else if (msg == 'unittest-suite-success') {
     dartPrint('PASS');
-    if (testRunner) testRunner.notifyDone();
-    sendDomToTestDriver();
+    notifyDone();
   } else if (msg == 'unittest-suite-fail') {
     showErrorAndExit('Some tests failed.');
   }
 }
 
 function onReceive(e) {
   processMessage(e.data);
 }
 
 if (testRunner) {
   testRunner.dumpAsText();
   testRunner.waitUntilDone();
 }
 window.addEventListener("message", onReceive, false);
 
 function showErrorAndExit(message) {
   if (message) {
     dartPrint('Error: ' + String(message));
   }
   // dart/tools/testing/run_selenium.py is looking for either PASS or
   // FAIL and will continue polling until one of these words show up.
   dartPrint('FAIL');
-  if (testRunner) testRunner.notifyDone();
-  sendDomToTestDriver();
+  nofityDone();
 }
 
 function onLoad(e) {
   // needed for dartium compilation errors.
   if (window.compilationError) {
     showErrorAndExit(window.compilationError);
   }
 }
 
 window.addEventListener("DOMContentLoaded", onLoad, false);
@@ skipping 14 matching lines @@
   if (document.readyState != "loaded") return;
   // If 'startedDartTest' is not set, that means that the test did not have
   // a chance to load. This will happen when a load error occurs in the VM.
   // Give the machine time to start up.
   setTimeout(function() {
     // A window.postMessage might have been enqueued after this timeout.
     // Just sleep another time to give the browser the time to process the
     // posted message.
     setTimeout(function() {
       if (testRunner && !testRunner.startedDartTest) {
-        testRunner.notifyDone();
-        sendDomToTestDriver();
+        notifyDone();
       }
     }, 0);
   }, 50);
 });
 
 // dart2js will generate code to call this function to handle the Dart
 // [print] method. The base [Configuration] (config.html) calls
 // [print] with the secret messages "unittest-suite-success" and
 // "unittest-suite-wait-for-done". These messages are then posted so
 // processMessage above will see them.
@@ skipping 15 matching lines @@
   try {
     main();
   } catch (e) {
     dartPrint(e);
     if (e.stack) dartPrint(e.stack);
     window.postMessage('unittest-suite-fail', '*');
     return;
   }
   window.postMessage('dart-main-done', '*');
 }