Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1574183002: Split SVG1DOM counter further (Closed)

Created:
4 years, 11 months ago by davve
Modified:
4 years, 11 months ago
Reviewers:
Ilya Sherman, fs
CC:
fs, asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split SVG1DOM counter further Split all counters relating to basic data types into smaller parts. Use MeasureAs when these interfaces are implemented by multiple other interfaces. Using Measure for them would give a lot of unnecessary UseCounters. It seems more likely that we try to remove interface methods in its entirety than splitting the interface, moving some and removing some. Also remove the counter from constants in affected interfaces. If we get to remove the interfaces where the constants are used, they can go too. Otherwise they likely have to stay. BUG=415074 Committed: https://crrev.com/099be58b08dadb64b1dc9f359ae097e978df5416 Cr-Commit-Position: refs/heads/master@{#369139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGURIReference.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUnitTypes.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGZoomAndPan.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
davve
Less clear how to group the remaining SVG1DOM counters so trying to group as little ...
4 years, 11 months ago (2016-01-12 08:14:06 UTC) #2
fs
lgtm
4 years, 11 months ago (2016-01-12 09:23:09 UTC) #3
Ilya Sherman
histograms.xml lgtm
4 years, 11 months ago (2016-01-13 00:58:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574183002/1
4 years, 11 months ago (2016-01-13 09:37:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 11:01:05 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 11:02:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/099be58b08dadb64b1dc9f359ae097e978df5416
Cr-Commit-Position: refs/heads/master@{#369139}

Powered by Google App Engine
This is Rietveld 408576698