Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1574133002:
[DevTools] Added base SourceMap implementation on backend (Closed)
|
Created:
4 years, 11 months ago by kozy Modified:
4 years, 11 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Added base SourceMap implementation on backend
This class will be used in next CL for parsing inline source maps on backend side. We need to parse it for skipping pauses in blackboxed sources with source maps.
BUG=341082
R=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org
Committed: https://crrev.com/3136a502672cbdae1cc51c93b5ab3b79e778416d
Cr-Commit-Position: refs/heads/master@{#369618}
Patch Set 1 #Patch Set 2 : #
Total comments: 2
Patch Set 3 : #Patch Set 4 : #
Total comments: 24
Patch Set 5 : #Patch Set 6 : Added missing headers #
Total comments: 2
Patch Set 7 : #Patch Set 8 : #Patch Set 9 : #
Messages
Total messages: 45 (20 generated)
ptal!
https://codereview.chromium.org/1574133002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp (right): https://codereview.chromium.org/1574133002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp:53: // Generate test by SourceMap.js and add. delete comment
All done! https://codereview.chromium.org/1574133002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp (right): https://codereview.chromium.org/1574133002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp:53: // Generate test by SourceMap.js and add. On 2016/01/12 02:03:35, lushnikov wrote: > delete comment Done.
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574133002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== [DevTools] Added base SourceMap implementation on backend This class will be used in next CL for parsing inline source maps on backend side. We need to parse it for skipping pauses in blackboxed sources with source maps. BUG=341082 R=pfeldman@chromium.org,lushnikov@chromium.org ========== to ========== [DevTools] Added base SourceMap implementation on backend This class will be used in next CL for parsing inline source maps on backend side. We need to parse it for skipping pauses in blackboxed sources with source maps. BUG=341082 R=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org ==========
kozyatinskiy@chromium.org changed reviewers: + dgozman@chromium.org
Dmitry, please take a look!
https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp (right): https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:31: bool jsonStringArrayAsVector(PassRefPtr<blink::JSONArray> jsonArray, Vector<String>& vector, bool mandatory) What is this converting and where? https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:47: class StringPeekIterator { how is this better than iterating over array? https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:60: int base64SymbolToNumber(UChar sym) Can you use Base64.h? https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:102: static bool operator<(const blink::SourceMap::Entry& e1, const blink::SourceMap::Entry& e2) We should not overload operators if possible.
https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp (right): https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:13: const char* kVersionString = "version"; const char kVersionString[] = "version"; https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:31: bool jsonStringArrayAsVector(PassRefPtr<blink::JSONArray> jsonArray, Vector<String>& vector, bool mandatory) Non-const references are not allowed. https://google.github.io/styleguide/cppguide.html#Reference_Arguments https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:97: int sourceLine, int sourceColumn) : line(line), column(column), Kind of strange formatting. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:138: auto it = std::lower_bound(m_mappings.begin(), m_mappings.end(), SourceMap::Entry(line, column)); I don't think creating temporary with a bunch of fields (including strings) is a good idea. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/v8/SourceMap.h (right): https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.h:8: #include "bindings/core/v8/Nullable.h" We cannot depend on bindings. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.h:26: Entry(int line, int column, const String& sourceURL = String(), int sourceLine = 0, int sourceColumn = 0); Let's not have default parameter String(). https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp (right): https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp:32: Nullable<SourceMap> sourceMap = SourceMap::parse("{\"version\":3,\"sources\":[\"fib.js\"],\"names\":[],\"mappings\":\";;eAEU,SAAS;;AAFnB,OAAO,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;;AAEvB,SAAU,SAAS;MACb,GAAG,EACH,GAAG,EAED,OAAO,EAGP,KAAK;;;;AANP,WAAG,GAAG,CAAC;AACP,WAAG,GAAG,CAAC;;;aACJ,IAAI;;;;;AACL,eAAO,GAAG,GAAG;;AACjB,WAAG,GAAG,GAAG,CAAC;AACV,WAAG,GAAG,GAAG,GAAG,OAAO,CAAC;;eACF,OAAO;;;AAArB,aAAK;;AACT,YAAI,KAAK,EAAC;AACN,aAAG,GAAG,CAAC,CAAC;AACR,aAAG,GAAG,CAAC,CAAC;SACX;;;;;;;;;CAEJ;;AAED,IAAI,QAAQ,GAAG,SAAS,EAAE,CAAC;AAC3B,IAAI,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,EAAE,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC;AAC/C,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,EAAE,EAAE,CAAC;AAC5B,SAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC;CAAA\",\"file\":\"fib-compiled.js\",\"sourcesContent\":[null]}"); Maybe split the literal for readability? https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp:53: Nullable<SourceMap> sourceMap = SourceMap::parse("{\"version\":3,\"sources\":[\"fib.js\"],\"names\":[],\"mappings\":\";;eAEU,SAAS;;AAFnB,OAAO,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;;AAEvB,SAAU,SAAS;MACb,GAAG,EACH,GAAG,EAED,OAAO,EAGP,KAAK;;;;AANP,WAAG,GAAG,CAAC;AACP,WAAG,GAAG,CAAC;;;aACJ,IAAI;;;;;AACL,eAAO,GAAG,GAAG;;AACjB,WAAG,GAAG,GAAG,CAAC;AACV,WAAG,GAAG,GAAG,GAAG,OAAO,CAAC;;eACF,OAAO;;;AAArB,aAAK;;AACT,YAAI,KAAK,EAAC;AACN,aAAG,GAAG,CAAC,CAAC;AACR,aAAG,GAAG,CAAC,CAAC;SACX;;;;;;;;;CAEJ;;AAED,IAAI,QAAQ,GAAG,SAAS,EAAE,CAAC;AAC3B,IAAI,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,EAAE,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC;AAC/C,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,EAAE,EAAE,CAAC;AAC5B,SAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC;CAAA\",\"file\":\"fib-compiled.js\",\"sourcesContent\":[null]}"); ditto
Patchset #5 (id:80001) has been deleted
All done. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp (right): https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:13: const char* kVersionString = "version"; On 2016/01/13 01:07:24, dgozman wrote: > const char kVersionString[] = "version"; Done. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:31: bool jsonStringArrayAsVector(PassRefPtr<blink::JSONArray> jsonArray, Vector<String>& vector, bool mandatory) On 2016/01/13 01:07:25, dgozman wrote: > Non-const references are not allowed. > https://google.github.io/styleguide/cppguide.html#Reference_Arguments Done. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:31: bool jsonStringArrayAsVector(PassRefPtr<blink::JSONArray> jsonArray, Vector<String>& vector, bool mandatory) On 2016/01/13 00:21:46, pfeldman wrote: > What is this converting and where? Acknowledged. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:47: class StringPeekIterator { On 2016/01/13 00:21:46, pfeldman wrote: > how is this better than iterating over array? I tried to reimplement it without iterator. It looks worse. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:60: int base64SymbolToNumber(UChar sym) On 2016/01/13 00:21:46, pfeldman wrote: > Can you use Base64.h? It uses for VLQ decoding here, so we can't reuse Base64.h. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:97: int sourceLine, int sourceColumn) : line(line), column(column), On 2016/01/13 01:07:25, dgozman wrote: > Kind of strange formatting. Done. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:102: static bool operator<(const blink::SourceMap::Entry& e1, const blink::SourceMap::Entry& e2) On 2016/01/13 00:21:46, pfeldman wrote: > We should not overload operators if possible. Done. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:138: auto it = std::lower_bound(m_mappings.begin(), m_mappings.end(), SourceMap::Entry(line, column)); On 2016/01/13 01:07:24, dgozman wrote: > I don't think creating temporary with a bunch of fields (including strings) is a > good idea. Added OwnPtrs everywhere! https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/v8/SourceMap.h (right): https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.h:8: #include "bindings/core/v8/Nullable.h" On 2016/01/13 01:07:25, dgozman wrote: > We cannot depend on bindings. Removed. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMap.h:26: Entry(int line, int column, const String& sourceURL = String(), int sourceLine = 0, int sourceColumn = 0); On 2016/01/13 01:07:25, dgozman wrote: > Let's not have default parameter String(). Acknowledged. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp (right): https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp:32: Nullable<SourceMap> sourceMap = SourceMap::parse("{\"version\":3,\"sources\":[\"fib.js\"],\"names\":[],\"mappings\":\";;eAEU,SAAS;;AAFnB,OAAO,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;;AAEvB,SAAU,SAAS;MACb,GAAG,EACH,GAAG,EAED,OAAO,EAGP,KAAK;;;;AANP,WAAG,GAAG,CAAC;AACP,WAAG,GAAG,CAAC;;;aACJ,IAAI;;;;;AACL,eAAO,GAAG,GAAG;;AACjB,WAAG,GAAG,GAAG,CAAC;AACV,WAAG,GAAG,GAAG,GAAG,OAAO,CAAC;;eACF,OAAO;;;AAArB,aAAK;;AACT,YAAI,KAAK,EAAC;AACN,aAAG,GAAG,CAAC,CAAC;AACR,aAAG,GAAG,CAAC,CAAC;SACX;;;;;;;;;CAEJ;;AAED,IAAI,QAAQ,GAAG,SAAS,EAAE,CAAC;AAC3B,IAAI,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,EAAE,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC;AAC/C,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,EAAE,EAAE,CAAC;AAC5B,SAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC;CAAA\",\"file\":\"fib-compiled.js\",\"sourcesContent\":[null]}"); On 2016/01/13 01:07:25, dgozman wrote: > Maybe split the literal for readability? Done. https://codereview.chromium.org/1574133002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp:53: Nullable<SourceMap> sourceMap = SourceMap::parse("{\"version\":3,\"sources\":[\"fib.js\"],\"names\":[],\"mappings\":\";;eAEU,SAAS;;AAFnB,OAAO,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;;AAEvB,SAAU,SAAS;MACb,GAAG,EACH,GAAG,EAED,OAAO,EAGP,KAAK;;;;AANP,WAAG,GAAG,CAAC;AACP,WAAG,GAAG,CAAC;;;aACJ,IAAI;;;;;AACL,eAAO,GAAG,GAAG;;AACjB,WAAG,GAAG,GAAG,CAAC;AACV,WAAG,GAAG,GAAG,GAAG,OAAO,CAAC;;eACF,OAAO;;;AAArB,aAAK;;AACT,YAAI,KAAK,EAAC;AACN,aAAG,GAAG,CAAC,CAAC;AACR,aAAG,GAAG,CAAC,CAAC;SACX;;;;;;;;;CAEJ;;AAED,IAAI,QAAQ,GAAG,SAAS,EAAE,CAAC;AAC3B,IAAI,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,EAAE,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC;AAC/C,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,EAAE,EAAE,CAAC;AAC5B,SAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC;CAAA\",\"file\":\"fib-compiled.js\",\"sourcesContent\":[null]}"); On 2016/01/13 01:07:25, dgozman wrote: > ditto Done.
lgtm https://codereview.chromium.org/1574133002/diff/120001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp (right): https://codereview.chromium.org/1574133002/diff/120001/third_party/WebKit/Sou... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:156: auto it = std::lower_bound(m_mappings.begin(), m_mappings.end(), std::make_pair(line, column), entryCompareWithTarget); I think upper_bound would work perfectly.
The CQ bit was checked by kozyatinskiy@chromium.org
thanks! https://codereview.chromium.org/1574133002/diff/120001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp (right): https://codereview.chromium.org/1574133002/diff/120001/third_party/WebKit/Sou... third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:156: auto it = std::lower_bound(m_mappings.begin(), m_mappings.end(), std::make_pair(line, column), entryCompareWithTarget); On 2016/01/14 00:08:01, dgozman wrote: > I think upper_bound would work perfectly. Acknowledged.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574133002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574133002/120001
The CQ bit was unchecked by kozyatinskiy@chromium.org
The CQ bit was checked by kozyatinskiy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/1574133002/#ps140001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574133002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574133002/140001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574133002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574133002/140001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574133002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574133002/140001
The CQ bit was checked by kozyatinskiy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org, pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/1574133002/#ps160001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574133002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574133002/160001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by kozyatinskiy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org, pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/1574133002/#ps180001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574133002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574133002/180001
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Added base SourceMap implementation on backend This class will be used in next CL for parsing inline source maps on backend side. We need to parse it for skipping pauses in blackboxed sources with source maps. BUG=341082 R=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org ========== to ========== [DevTools] Added base SourceMap implementation on backend This class will be used in next CL for parsing inline source maps on backend side. We need to parse it for skipping pauses in blackboxed sources with source maps. BUG=341082 R=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #9 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Added base SourceMap implementation on backend This class will be used in next CL for parsing inline source maps on backend side. We need to parse it for skipping pauses in blackboxed sources with source maps. BUG=341082 R=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org ========== to ========== [DevTools] Added base SourceMap implementation on backend This class will be used in next CL for parsing inline source maps on backend side. We need to parse it for skipping pauses in blackboxed sources with source maps. BUG=341082 R=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org Committed: https://crrev.com/3136a502672cbdae1cc51c93b5ab3b79e778416d Cr-Commit-Position: refs/heads/master@{#369618} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/3136a502672cbdae1cc51c93b5ab3b79e778416d Cr-Commit-Position: refs/heads/master@{#369618}
Message was sent while issue was closed.
A revert of this CL (patchset #9 id:180001) has been created in https://codereview.chromium.org/1588053004/ by caseq@chromium.org. The reason for reverting is: Broke oilpan build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan....
Message was sent while issue was closed.
A revert of this CL (patchset #9 id:180001) has been created in https://codereview.chromium.org/1586763009/ by samuong@chromium.org. The reason for reverting is: looks like this is causing a compile failure: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%... . |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
