Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1574113002: Record information about parts of dependent libraries in summaries. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Record information about parts of dependent libraries in summaries. This information will be necessary in order to determine whether a summary needs to be re-linked, since a change to a part of library A may affect any other library that depends on library A, even if the defining compilation unit of library A is unaffected. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/85a7affb7c94cf953830e96fc7ddb7d71db9bfde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -17 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 4 chunks +43 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 8 chunks +54 lines, -10 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-12 00:27:37 UTC) #2
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-12 01:08:38 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-12 20:02:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
85a7affb7c94cf953830e96fc7ddb7d71db9bfde (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698