Stop using hard-codeed json files in drive::FileSystemTest.ChangeFeed* (part 1).

Stop using hard-codeed json in drive::FileSystemTest.ChangeFeed* (part 1).

It makes the test more self-contained.

This patch converts only the tests not involving file deletion feed,
which is not supported yet in FakeDriveService.

BUG=244316
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203045

[satorux1, 2013-05-28 05:01:32]

The changes in unittest.cc look good, but we'll lose some test coverage by this
change. I guess we should add unit tests for ChangeListProcessor before
submitting this change...

https://codereview.chromium.org/15741023/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/file_system_unittest.cc (left):

https://codereview.chromium.org/15741023/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/file_system_unittest.cc:666:
LoadChangeFeed("chromeos/gdata/delta_file_added_in_new_directory.json"));
Here, we were indirectly testing the ChangeListProcessor. The delta_* files
would be useful for testing ChangeListProcessor

Could you add unit tests for ChangeListProcessor in a separate patch? :)

[kinaba, 2013-05-28 06:20:27]

https://codereview.chromium.org/15741023/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/file_system_unittest.cc (left):

https://codereview.chromium.org/15741023/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/file_system_unittest.cc:666:
LoadChangeFeed("chromeos/gdata/delta_file_added_in_new_directory.json"));
On 2013/05/28 05:01:33, satorux1 wrote:
> Here, we were indirectly testing the ChangeListProcessor. The delta_* files
> would be useful for testing ChangeListProcessor
> 
> Could you add unit tests for ChangeListProcessor in a separate patch? :)

We are still testing ChangeListProcessor indirectly here (by the feed
generated from FakeDriveService). Actually the coverage is strictly
increasing since the new code indirectly uses ChangeListLoader as well.

But either yet, it sounds good to utilize delta_*_.json for separately
testing ChangeListProcessor. Reverted the file removal and
added new tests: https://codereview.chromium.org/15939005/.

[kinaba, 2013-05-29 23:52:07]

ChangeListProcessor unittests have landed. Could you please take a look once
again?

[satorux1, 2013-05-30 00:28:21]

LGTM

[commit-bot: I haz the power, 2013-05-30 00:33:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/15741023/15001

[commit-bot: I haz the power, 2013-05-30 03:35:20]

Change committed as 203045