runtime/lib/double.cc - Issue 15741019: Ensures that Bigints returned to Dart are all checked by Integer::AsValidInteger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/double.cc

Issue 15741019: Ensures that Bigints returned to Dart are all checked by Integer::AsValidInteger. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/double.cc

===================================================================

--- runtime/lib/double.cc (revision 23089)

+++ runtime/lib/double.cc (working copy)

@@ -80,11 +80,7 @@

Exceptions::ThrowByType(Exceptions::kUnsupported, args);

}

const Bigint& big = Bigint::Handle(BigintOperations::NewFromDouble(val));

- if (BigintOperations::FitsIntoInt64(big)) {

- return Integer::New(BigintOperations::ToInt64(big));

- } else {

- return big.raw();

- }

+ return big.AsValidInteger();

}

DEFINE_NATIVE_ENTRY(Double_trunc_div, 2) {

« no previous file with comments | « no previous file | runtime/lib/integers.cc » ('j') | runtime/lib/integers.cc » ('J')